public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: "Mathieu Dubois-Briand" <mathieu.dubois-briand@bootlin.com>
To: <adam.duskett@amarulasolutions.com>,
	<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH v7 1/6] signing-keys.bb: Fix DISTRO_CODENAME truncation
Date: Tue, 31 Mar 2026 09:56:04 +0200	[thread overview]
Message-ID: <DHGT1WW8V5AK.Z5TAGIFLEW4F@bootlin.com> (raw)
In-Reply-To: <20260330095849.119621-1-adam.duskett@amarulasolutions.com>

On Mon Mar 30, 2026 at 11:58 AM CEST, Adam Duskett via lists.openembedded.org wrote:
> If DISTRO_CODENAME is not set in the environment, bash quietly
> drops the string resulting in a key such as PACKAGEFEED-GPG-KEY-defaultsetup-
>
> However, when python calls self.d.getVar('DISTRO_CODENAME'), the resulting
> string is 'None', leading to a configuration file pointing to a key such
> as PACKAGEFEED-GPG-KEY-defaultsetup-None
>
> Add a default value in signing-keys.bb to set DISTRO_CODENAME to None if
> DISTRO_CODENAME is not set.
>
> Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com>
> ---

Hi Adam,

Thanks for your patch.

It looks like we get some new warning with this patch:

WARNING: core-image-minimal-1.0-r0 do_rootfs: [log_check] core-image-minimal: found 1 warning message in the logfile:
[log_check] Warning: skipped OpenPGP checks for 39 packages from repository: oe-repo

It appears in most builds on the autobuilder:

https://autobuilder.yoctoproject.org/valkyrie/#/builders/11/builds/3461
https://autobuilder.yoctoproject.org/valkyrie/#/builders/78/builds/3521
https://autobuilder.yoctoproject.org/valkyrie/#/builders/89/builds/3342
...

Can you have a look at the issue?

Thanks,
Mathieu

-- 
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com



      parent reply	other threads:[~2026-03-31  7:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-30  9:58 [PATCH v7 1/6] signing-keys.bb: Fix DISTRO_CODENAME truncation Adam Duskett
2026-03-30  9:58 ` [PATCH v7 2/6] libtoml11: new recipe Adam Duskett
2026-03-30  9:58 ` [PATCH v7 3/6] libsolv: explicitly enable comps for rpm packageconfig Adam Duskett
2026-03-30  9:58 ` [PATCH v7 4/6] librepo: add PACKAGECONFIG[sequoia] Adam Duskett
2026-03-30  9:58 ` [PATCH v7 5/6] dnf: Upgrade to 5.4.0.0 Adam Duskett
2026-04-01 13:54   ` [OE-core] " Mathieu Dubois-Briand
2026-04-01 13:56     ` Mathieu Dubois-Briand
2026-03-30  9:58 ` [PATCH v7 6/6] libdnf: remove recipe Adam Duskett
2026-03-31  7:56 ` Mathieu Dubois-Briand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DHGT1WW8V5AK.Z5TAGIFLEW4F@bootlin.com \
    --to=mathieu.dubois-briand@bootlin.com \
    --cc=adam.duskett@amarulasolutions.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox