public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: "Antonin Godard" <antonin.godard@bootlin.com>
To: "Benjamin Robin" <benjamin.robin@bootlin.com>,
	<openembedded-core@lists.openembedded.org>
Cc: <richard.purdie@linuxfoundation.org>, <rybczynska@gmail.com>,
	<ross.burton@arm.com>, <peter.marko@siemens.com>,
	<jpewhacker@gmail.com>, <olivier.benjamin@bootlin.com>,
	<mathieu.dubois-briand@bootlin.com>,
	<thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v2 2/2] sbom-cve-check-update-db: Fix unpack removing other databases
Date: Tue, 07 Apr 2026 17:27:55 +0200	[thread overview]
Message-ID: <DHN11ORFP49K.2PWSARK0B4AW6@bootlin.com> (raw)
In-Reply-To: <20260407-fix-lic-sbom-cve-check-v2-2-f69da412fd67@bootlin.com>

Hi,

On Tue Apr 7, 2026 at 5:01 PM CEST, Benjamin Robin wrote:
> Previously, `UNPACKDIR` was set to `${SBOM_CVE_CHECK_DEPLOY_DB_DIR}`,
> which points to the `./databases/` directory and may contain multiple
> databases. Since `do_unpack` cleans the `${UNPACKDIR}` directory,
> `UNPACKDIR` must only contain a single database.
>
> To address this, set `UNPACKDIR` to
> `${SBOM_CVE_CHECK_DEPLOY_DB_DIR}/${SBOM_CVE_CHECK_DB_NAME}` and
> configure `destsuffix` to an empty string. However, it is currently not
> possible to set `BB_GIT_DEFAULT_DESTSUFFIX` to an empty string, so
> `destsuffix` is configured through the SRC_URI instead.

I've tested this the following way, first by unpacking the databases with:

SRCREV:pn-sbom-cve-check-update-nvd-native = "ba5e43861ba2ca0f7968597c27c6a412c1bfa8c2"
SRCREV:pn-sbom-cve-check-update-cvelist-native = "6740b38b3e0692bb9c96eb226371ae9e1217c1fd"

Then created a random file in the nvd database checkout:

touch tmp/deploy/sbom-cve-check/databases/nvd-fkie/file.txt

Then I updated the sha for cvelist only:

SRCREV:pn-sbom-cve-check-update-nvd-native = "ba5e43861ba2ca0f7968597c27c6a412c1bfa8c2"
SRCREV:pn-sbom-cve-check-update-cvelist-native = "42e75c927b155335cb1119df9d9b85a58732ad1e"

Ran the unpack again, and file.txt is still there.

Doing the same without this patch, you'd get:

$ ls -l tmp/deploy/sbom-cve-check/databases/nvd-fkie
"tmp/deploy/sbom-cve-check/databases/nvd-fkie": No such file or directory (os error 2)

This fixes the issue for me too, so feel free to add:

Tested-by: Antonin Godard <antonin.godard@bootlin.com>

Antonin


      reply	other threads:[~2026-04-07 15:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-07 15:01 [PATCH v2 0/2] sbom-cve-check-update-db: Fix various failures Benjamin Robin
2026-04-07 15:01 ` [PATCH v2 1/2] sbom-cve-check-update-db: Fix do_populate_lic failure Benjamin Robin
2026-04-07 15:01 ` [PATCH v2 2/2] sbom-cve-check-update-db: Fix unpack removing other databases Benjamin Robin
2026-04-07 15:27   ` Antonin Godard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DHN11ORFP49K.2PWSARK0B4AW6@bootlin.com \
    --to=antonin.godard@bootlin.com \
    --cc=benjamin.robin@bootlin.com \
    --cc=jpewhacker@gmail.com \
    --cc=mathieu.dubois-briand@bootlin.com \
    --cc=olivier.benjamin@bootlin.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=peter.marko@siemens.com \
    --cc=richard.purdie@linuxfoundation.org \
    --cc=ross.burton@arm.com \
    --cc=rybczynska@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox