Re: [OE-core] [whinlatter][PATCH 1/9] dtc: backport fix for build with glibc-2.43

["Yoann Congal" <yoann.congal@smile.fr>]

On Fri Apr 10, 2026 at 11:09 AM CEST, Martin Jansa wrote:
> On Fri, Apr 10, 2026 at 9:42 AM Yoann Congal <yoann.congal@smile.fr> wrote:
>>
>> On Thu Apr 9, 2026 at 11:29 PM CEST, Martin Jansa wrote:
>> > On Thu, Apr 9, 2026 at 9:17 PM Yoann Congal <yoann.congal@smile.fr> wrote:
>> >>
>> >> On Thu Apr 9, 2026 at 5:28 PM CEST, Martin Jansa via lists.openembedded.org wrote:
>> >> > From: Martin Jansa <martin.jansa@gmail.com>
>> >> >
>> >> > glibc-2.43 isn't used in OE builds yet, but this fixes dtc-native:
>> >> > https://errors.yoctoproject.org/Errors/Details/903983/
>> >> >
>> >> > ../sources/dtc-1.7.2/libfdt/fdt_overlay.c: In function ‘overlay_fixup_phandle’:
>> >> > ../sources/dtc-1.7.2/libfdt/fdt_overlay.c:424:21: error: assignment discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
>> >> >   424 |                 sep = memchr(fixup_str, ':', fixup_len);
>> >> >       |                     ^
>> >> > ../sources/dtc-1.7.2/libfdt/fdt_overlay.c:434:21: error: assignment discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
>> >> >   434 |                 sep = memchr(name, ':', fixup_len);
>> >> >       |                     ^
>> >> > cc1: all warnings being treated as errors
>> >> >
>> >> > Signed-off-by: Martin Jansa <martin.jansa@gmail.com>
>> >> > Signed-off-by: Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com>
>> >> > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
>> >> > ---
>> >>
>> >> Hello,
>> >>
>> >> I've started a whinlatter bringup build on the new Ubuntu 26.04 worker
>> >> with this series applied:
>> >> https://autobuilder.yoctoproject.org/valkyrie/#/builders/96/builds/23
>> >>
>> >> It got 2 errors (Other errors are most likely consequences of these ones):
>> >>
>> >> ERROR: shadow-native-4.18.0-r0 do_configure: configure failed:
>> >> https://autobuilder.yoctoproject.org/valkyrie/?#/builders/96/builds/23/steps/12/logs/stdio line 6269:
>> >> | checking for crypt in -lcrypt... no
>> >> | configure: error: crypt() not found
>> >> | NOTE: The following config.log files may provide further information.
>> >> | NOTE: /srv/pokybuild/yocto-worker/bringup/build/build/tmp/work/x86_64-linux/shadow-native/4.18.0/build/config.log
>> >> | ERROR: configure failed
>> >> | WARNING: exit code 1 from a shell command.
>> >> NOTE: recipe shadow-native-4.18.0-r0: task do_configure: Failed
>> >
>> > Hello,
>> >
>> > for shadow please read
>> > https://lists.openembedded.org/g/openembedded-core/message/234119 the
>> > important part:
>> > "libcrypt-dev is no longer installed as a dependency in my minimal docker image"
>> > I guess it's now missing on your ubuntu-26.04 host as well.
>> > It used to be typically installed by build-essential -> libc6-dev ->
>> > libcrypt-dev but not anymore since 2.42-7:
>> >
>> > 25.10 questing with 2.42-0ubuntu3.1:
>> > https://packages.ubuntu.com/questing/libc6-dev
>> > 26.04 resolute with 2.43-2ubuntu1:
>> > https://packages.ubuntu.com/resolute/libc6-dev
>> >
>> > https://changelogs.ubuntu.com/changelogs/pool/main/g/glibc/glibc_2.43-2ubuntu1/changelog:
>> > ...
>> > glibc (2.42-7) unstable; urgency=medium
>> >
>> >   [ Aurelien Jarno ]
>> >   * debian/control.in/libc, debian/rules.d/debhelper.mk: drop libcrypt-dev
>> >     dependency from libc6-dev. Thanks to Helmut Grohne for proposing that,
>> >     doing an archive rebuild and filling the bug reports.
>> >   * debian/control.in/main, debian/sysdeps/linux.mk: enable SystemTap static
>> >     probes.
>> >   * debian/debhelper.in/libc-dev.NEWS: add a NEWS entry about the removal of
>> >     the obsolete termio interface.  Closes: #1124068.
>> >   * debian/rules.d/debhelper.mk: ensure that linker scripts work even when
>> >     /usr is unmerged.  Closes: #1120508
>> >   * debian/debhelper.in/libc-dev{,-alt}.lintian-overrides,
>> >     source/lintian-overrides, rules.d/debhelper.mk, salsa-ci.yml: drop
>> >     unpack-message-for-{orig,source} overrides, fixed in lintian 2.128.0.
>> >   * debian/control.in/main: drop Rules-Requires-Root: no, this is now the
>> >     default.
>> >   * debian/libc6.symbols.i386, debian/libc6-i386.symbols.{amd64,x32}: remove
>> >     the workaround for GLIBC_ABI_GNU_TLS.  Closes: #1122038.
>> >   * debian/control.in/{libc,i386}: ensure that libdpkg-perl is fixed wrt
>> >     GLIBC_ABI_GNU_TLS.
>> >
>> >  -- Aurelien Jarno <aurel32@debian.org>  Sun, 04 Jan 2026 10:07:24 +0100
>> > ...
>>
>> Hello,
>>
>> In that case, shouldn't we remove "virtual/crypt-native" from ASSUME_PROVIDED?
>> https://git.openembedded.org/openembedded-core/tree/meta/conf/bitbake.conf#n232
>>
>> I've tried it but then libxcrypt-native fails to build with:
>> | ../sources/libxcrypt-4.4.38/lib/crypt-gost-yescrypt.c: In function ‘_crypt_crypt_gost_yescrypt_rn’:
>> | ../sources/libxcrypt-4.4.38/lib/crypt-gost-yescrypt.c:134:16: error: initialization discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
>> |   134 |   char *hptr = strchr ((const char *) intbuf->retval + 3, '$');
>> |       |                ^~~~~~
>> | cc1: all warnings being treated as errors
>>
>> It looks like the fixes for that are on master but the patches don't
>> apply.
>>
>> Can you send an update series with those fixes?
>
>
> Patches for building libxcrypt-native? I still see
> virtual/crypt-native in ASSUME_PROVIDED in master, that's why I've
> added libcrypt-dev into the ubuntu-26.04 image at least until the same
> is resolved in wrynose/master. The same issue is in current master.

(Sorry, our mails crossed)

I discussed that with Paul. He suggested to add libcrypt-dev as a host
dependency instead (ie. what you describe). I agree (sorry about the
sudden change of heart).

Can you send the yocto-docs patch to do this?
-- 
Yoann Congal
Smile ECS