public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: "Mathieu Dubois-Briand" <mathieu.dubois-briand@bootlin.com>
To: <richard.purdie@linuxfoundation.org>, <raj.khem@gmail.com>,
	<openembedded-core@lists.openembedded.org>
Cc: "Khem Raj" <khem.raj@oss.qualcomm.com>
Subject: Re: [OE-core] [PATCH] db: Pin to use C99 std
Date: Fri, 10 Apr 2026 15:38:54 +0200	[thread overview]
Message-ID: <DHPILUGFBYND.3S81A028WPCOE@bootlin.com> (raw)
In-Reply-To: <c8e3d16047191a697c26bfdfd7885fa8f560a7dc.camel@linuxfoundation.org>

On Fri Apr 10, 2026 at 3:15 PM CEST, Richard Purdie via lists.openembedded.org wrote:
> On Tue, 2026-04-07 at 21:47 -0700, Khem Raj via lists.openembedded.org wrote:
>> GCC-15 has switched to using C23 by default, we have been selectively
>> disabling warnings as errors to get by, however with autoconf 2.72 adding
>> -std=gnu23 it now gets enabled for every compiler and clang-22 is more
>> obidient and has dropped support for K&R C completely. db5 code has a lot
>> of K&R C prototypes and it starts to fail vigorously. We can not keep
>> working around with out uplifting sources to be compliant with newer C
>> standard like C23.
>> 
>> Therefore pin the cflags to use C99 standard as this package expects.
>> 
>> Drop the code to disable warnings as errors selectively.
>> 
>> Signed-off-by: Khem Raj <khem.raj@oss.qualcomm.com>
>> ---
>>  meta/recipes-support/db/db_5.3.28.bb | 9 ++++-----
>>  1 file changed, 4 insertions(+), 5 deletions(-)
>
> This seemed to trigger failures for me, e.g.:
>
> https://autobuilder.yoctoproject.org/valkyrie/#/builders/74/builds/3538#bb-step-15
>
> Cheers,
>
> Richard

This is because the patch is touching lines ending with spaces, and
these spaces have not been kept in the mail.

I tweaked the patch to make it work correctly, it landed in my -success
branch.

Thanks,
Mathieu


-- 
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com



  reply	other threads:[~2026-04-10 13:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-08  4:47 [PATCH] db: Pin to use C99 std Khem Raj
2026-04-10 13:15 ` [OE-core] " Richard Purdie
2026-04-10 13:38   ` Mathieu Dubois-Briand [this message]
2026-04-10 14:00     ` Khem Raj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DHPILUGFBYND.3S81A028WPCOE@bootlin.com \
    --to=mathieu.dubois-briand@bootlin.com \
    --cc=khem.raj@oss.qualcomm.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=raj.khem@gmail.com \
    --cc=richard.purdie@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox