Re: [OE-core][whinlatter][PATCH v3] nghttp2: upgrade 1.66.0 -> 1.68.1

["Yoann Congal" <yoann.congal@smile.fr>]

Hello,

On Thu Apr 2, 2026 at 5:45 PM CEST, Ashish Sharma via lists.openembedded.org wrote:
> Upgrade nghttp2 to 1.68.1 which includes upstream security fixes and improvements since 1.66.0.
>
> Changelog:
> https://github.com/nghttp2/nghttp2/releases/tag/v1.67.0
> https://github.com/nghttp2/nghttp2/releases/tag/v1.67.1
> https://github.com/nghttp2/nghttp2/releases/tag/v1.68.0
> https://github.com/nghttp2/nghttp2/releases/tag/v1.68.1

Thanks for the patch but this upgrade mixes features addition and
bugfixes and can't be accepted for stable branches.
For more details, see https://wiki.yoctoproject.org/wiki/Stable_Release_and_LTS#Stable/LTS_Patch_Acceptance_Policies

Regards,

>
> CC: <ashissh7@cisco.com>
>
> Signed-off-by: Ashish Sharma <pahaditechie@gmail.com>
> ---
>  ...xt-Fix-NGHTTP2_CONFIG_INSTALL_DIR-pa.patch | 28 +++++++++++++++++++
>  .../{nghttp2_1.66.0.bb => nghttp2_1.68.1.bb}  |  8 ++++--
>  2 files changed, 34 insertions(+), 2 deletions(-)
>  create mode 100644 meta/recipes-support/nghttp2/nghttp2/0001-lib-CMakeLists.txt-Fix-NGHTTP2_CONFIG_INSTALL_DIR-pa.patch
>  rename meta/recipes-support/nghttp2/{nghttp2_1.66.0.bb => nghttp2_1.68.1.bb} (62%)
>
> diff --git a/meta/recipes-support/nghttp2/nghttp2/0001-lib-CMakeLists.txt-Fix-NGHTTP2_CONFIG_INSTALL_DIR-pa.patch b/meta/recipes-support/nghttp2/nghttp2/0001-lib-CMakeLists.txt-Fix-NGHTTP2_CONFIG_INSTALL_DIR-pa.patch
> new file mode 100644
> index 0000000000..f7cc4fe539
> --- /dev/null
> +++ b/meta/recipes-support/nghttp2/nghttp2/0001-lib-CMakeLists.txt-Fix-NGHTTP2_CONFIG_INSTALL_DIR-pa.patch
> @@ -0,0 +1,28 @@
> +From eb5812d018eb96284aa6ef82569d0b6b75bcd020 Mon Sep 17 00:00:00 2001
> +From: Ankur Tyagi <ankur.tyagi85@gmail.com>
> +Date: Sun, 9 Nov 2025 12:45:25 +1300
> +Subject: [PATCH] lib/CMakeLists.txt: Fix NGHTTP2_CONFIG_INSTALL_DIR path
> +
> +Remove hard coded path to fix installation on 64-bit arch.
> +
> +Upstream-Status: Submitted [https://github.com/nghttp2/nghttp2/pull/2551]
> +Signed-off-by: Ankur Tyagi <ankur.tyagi85@gmail.com>
> +---
> + lib/CMakeLists.txt | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/lib/CMakeLists.txt b/lib/CMakeLists.txt
> +index 98e3dbe7..3b6a4400 100644
> +--- a/lib/CMakeLists.txt
> ++++ b/lib/CMakeLists.txt
> +@@ -51,7 +51,7 @@ set(NGHTTP2_GENERATED_DIR "${CMAKE_CURRENT_BINARY_DIR}/generated")
> + set(NGHTTP2_VERSION_CONFIG "${NGHTTP2_GENERATED_DIR}/${PROJECT_NAME}ConfigVersion.cmake")
> + set(NGHTTP2_PROJECT_CONFIG "${NGHTTP2_GENERATED_DIR}/${PROJECT_NAME}Config.cmake")
> + set(NGHTTP2_TARGETS_EXPORT_NAME "${PROJECT_NAME}Targets")
> +-set(NGHTTP2_CONFIG_INSTALL_DIR "lib/cmake/${PROJECT_NAME}")
> ++set(NGHTTP2_CONFIG_INSTALL_DIR "${CMAKE_INSTALL_LIBDIR}/cmake/${PROJECT_NAME}")
> + set(NGHTTP2_NAMESPACE "${PROJECT_NAME}::")
> + set(NGHTTP2_VERSION ${PROJECT_VERSION})
> +
> +--
> +2.43.0
> diff --git a/meta/recipes-support/nghttp2/nghttp2_1.66.0.bb b/meta/recipes-support/nghttp2/nghttp2_1.68.1.bb
> similarity index 62%
> rename from meta/recipes-support/nghttp2/nghttp2_1.66.0.bb
> rename to meta/recipes-support/nghttp2/nghttp2_1.68.1.bb
> index 49d6d7e632..71d5eef8d6 100644
> --- a/meta/recipes-support/nghttp2/nghttp2_1.66.0.bb
> +++ b/meta/recipes-support/nghttp2/nghttp2_1.68.1.bb
> @@ -4,8 +4,12 @@ SECTION = "libs"
>  LICENSE = "MIT"
>  LIC_FILES_CHKSUM = "file://COPYING;md5=764abdf30b2eadd37ce47dcbce0ea1ec"
>  
> -SRC_URI = "${GITHUB_BASE_URI}/download/v${PV}/nghttp2-${PV}.tar.xz"
> -SRC_URI[sha256sum] = "00ba1bdf0ba2c74b2a4fe6c8b1069dc9d82f82608af24442d430df97c6f9e631"
> +SRC_URI = "\
> +    ${GITHUB_BASE_URI}/download/v${PV}/nghttp2-${PV}.tar.xz \
> +    file://0001-lib-CMakeLists.txt-Fix-NGHTTP2_CONFIG_INSTALL_DIR-pa.patch \
> +"
> +
> +SRC_URI[sha256sum] = "6abd7ab0a7f1580d5914457cb3c85eb80455657ee5119206edbd7f848c14f0b2"
>  
>  inherit cmake manpages python3native github-releases
>  


-- 
Yoann Congal
Smile ECS