From: "Mathieu Dubois-Briand" <mathieu.dubois-briand@bootlin.com>
To: <mengshi.wu@oss.qualcomm.com>,
<openembedded-core@lists.openembedded.org>
Cc: <shuai.zhang@oss.qualcomm.com>, <cheng.jiang@oss.qualcomm.com>,
<chezhou@qti.qualcomm.com>, <wei.deng@oss.qualcomm.com>,
<yiboz@qti.qualcomm.com>, <jinwang.li@oss.qualcomm.com>
Subject: Re: [OE-core] [PATCH] bluez5: add patch to fix 8.56 gatt cache issue
Date: Sat, 30 May 2026 14:18:51 +0200 [thread overview]
Message-ID: <DIW07SLD8APO.2SRL8Q1GXY60P@bootlin.com> (raw)
In-Reply-To: <20f1b74e-69df-4f4e-8adc-bafcae25dfbf@oss.qualcomm.com>
On Fri May 29, 2026 at 6:06 AM CEST, Mengshi Wu via lists.openembedded.org wrote:
>> --- /dev/null
>> +++ b/meta/recipes-connectivity/bluez5/bluez5/0001-src-device-Fix-stored-gatt-cache-DB-Hash-value-no.patch
>> @@ -0,0 +1,84 @@
...
>> + └─> gatt_service_removed()
>> + └─> store_gatt_db() ← SAVED TO DISK (hash is NEW)
>> +
>> +There is a timing issue to update DB Hash value.
>> +
>> +The gatt_client_service_changed() callback in src/device.c is called
>> +from service_changed_complete() in gatt-client.c, which is invoked
>> +after db_hash_read_cb() has already updated the hash. Adding
>> +store_gatt_db(device) here guarantees the db is persisted with the
>> +correct, up-to-date hash for both the addition and removal cases.
>> +
>> +Signed-off-by: Mengshi Wu <mengshi.wu@oss.qualcomm.com>
>> +---
I also note you are missing the Upstream-Status line in this patch.
Thanks,
Mathieu
--
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2026-05-30 12:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260521062216.3352030-1-mengshi.wu@oss.qualcomm.com>
2026-05-29 4:06 ` [PATCH] bluez5: add patch to fix 8.56 gatt cache issue Mengshi Wu
2026-05-29 7:01 ` [OE-core] " Mathieu Dubois-Briand
2026-05-29 10:07 ` Mengshi Wu
2026-05-29 12:34 ` Mengshi Wu
2026-05-29 14:16 ` Mathieu Dubois-Briand
2026-05-29 14:31 ` Mengshi Wu
2026-05-30 12:18 ` Mathieu Dubois-Briand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DIW07SLD8APO.2SRL8Q1GXY60P@bootlin.com \
--to=mathieu.dubois-briand@bootlin.com \
--cc=cheng.jiang@oss.qualcomm.com \
--cc=chezhou@qti.qualcomm.com \
--cc=jinwang.li@oss.qualcomm.com \
--cc=mengshi.wu@oss.qualcomm.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=shuai.zhang@oss.qualcomm.com \
--cc=wei.deng@oss.qualcomm.com \
--cc=yiboz@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox