From: "Mathieu Dubois-Briand" <mathieu.dubois-briand@bootlin.com>
To: <marek.vasut@mailbox.org>, <openembedded-core@lists.openembedded.org>
Cc: "Adrian Freihofer" <adrian.freihofer@siemens.com>,
"Richard Purdie" <richard.purdie@linuxfoundation.org>,
"Yoann Congal" <yoann.congal@smile.fr>
Subject: Re: [OE-core] [PATCH] kernel-fit-image.bbclass: Fix operation with KERNEL_DTBVENDORED = "1"
Date: Thu, 18 Jun 2026 08:25:30 +0200 [thread overview]
Message-ID: <DJBYLLSOVDCK.3V9DIPDH2YV6M@bootlin.com> (raw)
In-Reply-To: <20260616214945.40714-1-marek.vasut@mailbox.org>
On Tue Jun 16, 2026 at 11:49 PM CEST, Marek Vasut via lists.openembedded.org wrote:
> In the case KERNEL_DTBVENDORED = "1" , the fitImage configuration
> subnode names used to contain the vendor prefix in OE 5.0 , e.g.:
> "
> $ mkimage -l fitImage
> ...
> Configuration 0 (conf-freescale_imx8mn-board.dtb)
> ^^^^^^^^^^
> ...
> "
>
> With OE 6.0 this is no longer the case and KERNEL_DTBVENDORED = "1"
> and KERNEL_DTBVENDORED = "0" behave exactly the same way:
> "
> $ mkimage -l fitImage
> ...
> Configuration 0 (conf-imx8mn-board.dtb)
> ...
> "
>
> Users depend on the correct configuration subnode names as those
> are used in the U-Boot "bootm" command when booting fitImages.
>
> Fix this by converting each entry in the KERNEL_DEVICETREE list
> into the configuration subnode name by replacing all of its path
> separators with underscores.
>
> Fixes: 05d0c7342d76 ("kernel-fit-image.bbclass: add a new FIT image implementation")
> Signed-off-by: Marek Vasut <marek.vasut@mailbox.org>
> ---
> Cc: Adrian Freihofer <adrian.freihofer@siemens.com>
> Cc: Richard Purdie <richard.purdie@linuxfoundation.org>
> Cc: Yoann Congal <yoann.congal@smile.fr>
> ---
> NOTE: This should ideally be added into OE 6.0 too
> ---
Hi Marek,
Thanks for your patch.
It looks like this is breaking the
fitimage.KernelFitImageRecipeTests.test_fit_image_ext_dtb_dtbo selftest:
2026-06-17 18:15:46,751 - oe-selftest - INFO - fitimage.KernelFitImageRecipeTests.test_fit_image_ext_dtb_dtbo (subunit.RemotedTestCase)
2026-06-17 18:15:46,752 - oe-selftest - INFO - ... FAIL
...
2026-06-17 18:15:46,752 - oe-selftest - INFO - 9: 36/79 281/688 (28.27s) (0 failed) (fitimage.KernelFitImageRecipeTests.test_fit_image_ext_dtb_dtbo)
2026-06-17 18:15:46,752 - oe-selftest - INFO - testtools.testresult.real._StringException: Traceback (most recent call last):
File "/srv/pokybuild/yocto-worker/oe-selftest-debian/build/layers/openembedded-core/meta/lib/oeqa/selftest/cases/fitimage.py", line 1259, in test_fit_image_ext_dtb_dtbo
self._test_fitimage(bb_vars)
File "/srv/pokybuild/yocto-worker/oe-selftest-debian/build/layers/openembedded-core/meta/lib/oeqa/selftest/cases/fitimage.py", line 646, in _test_fitimage
self._check_its_file(bb_vars, fitimage_its_path)
File "/srv/pokybuild/yocto-worker/oe-selftest-debian/build/layers/openembedded-core/meta/lib/oeqa/selftest/cases/fitimage.py", line 566, in _check_its_file
self.assertTrue(found_all,
File "/usr/lib/python3.12/unittest/case.py", line 727, in assertTrue
raise self.failureException(msg)
AssertionError: False is not true : Fields in Image Tree Source File /srv/pokybuild/yocto-worker/oe-selftest-debian/build/build-st-2472397/tmp/deploy/images/qemux86-64/fit-image.its did not match, error in finding fdt = "fdt-test-overlay.dtbo";
https://autobuilder.yoctoproject.org/valkyrie/#/builders/35/builds/4062
https://autobuilder.yoctoproject.org/valkyrie/#/builders/23/builds/4140
https://autobuilder.yoctoproject.org/valkyrie/#/builders/48/builds/3912
Can you have a look at the issue?
Thanks,
Mathieu
--
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2026-06-18 6:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-16 21:49 [PATCH] kernel-fit-image.bbclass: Fix operation with KERNEL_DTBVENDORED = "1" Marek Vasut
2026-06-18 6:25 ` Mathieu Dubois-Briand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DJBYLLSOVDCK.3V9DIPDH2YV6M@bootlin.com \
--to=mathieu.dubois-briand@bootlin.com \
--cc=adrian.freihofer@siemens.com \
--cc=marek.vasut@mailbox.org \
--cc=openembedded-core@lists.openembedded.org \
--cc=richard.purdie@linuxfoundation.org \
--cc=yoann.congal@smile.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox