From: "Mathieu Dubois-Briand" <mathieu.dubois-briand@bootlin.com>
To: <ross.burton@arm.com>, <openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH 1/3] classes/insane: increase shebang size limit
Date: Wed, 01 Jul 2026 13:28:13 +0200 [thread overview]
Message-ID: <DJN76GVF0HS6.3OSE79EMVNASR@bootlin.com> (raw)
In-Reply-To: <20260630140800.4018491-1-ross.burton@arm.com>
On Tue Jun 30, 2026 at 4:07 PM CEST, Ross Burton via lists.openembedded.org wrote:
> Since Linux 5.1 the shebang buffer has been 256 bytes[1], so update the
> check to match.
>
> Also rewrite the test, create a variable for the magic number (that has
> the same name as the kernel #define), don't pointlessly try to decode
> the bytes as UTF-8, and consolidate the test logic to entirely inside
> the try block.
>
> [1] linux 6eb3c3d0a52dc ("exec: increase BINPRM_BUF_SIZE to 256")
> ---
Hi Ross,
Thanks for your patch.
I believe you also need to update the test_sysroot_max_shebang selftest
/ sysroot-shebang-test-native recipe:
2026-07-01 11:25:35,511 - oe-selftest - INFO - FAIL: sysroot.SysrootTests.test_sysroot_max_shebang (subunit.RemotedTestCase)
2026-07-01 11:25:35,511 - oe-selftest - INFO - ----------------------------------------------------------------------
2026-07-01 11:25:35,511 - oe-selftest - INFO - testtools.testresult.real._StringException: Traceback (most recent call last):
File "/srv/pokybuild/yocto-worker/oe-selftest-debian/build/layers/openembedded-core/meta/lib/oeqa/selftest/cases/sysroot.py", line 49, in test_sysroot_max_shebang
self.assertTrue(expected in res.output, msg=res.output)
File "/usr/lib/python3.12/unittest/case.py", line 727, in assertTrue
raise self.failureException(msg)
AssertionError: False is not true : NOTE: Reconnecting to bitbake server...
https://autobuilder.yoctoproject.org/valkyrie/#/builders/35/builds/4183
https://autobuilder.yoctoproject.org/valkyrie/#/builders/48/builds/4010
Thanks,
Mathieu
--
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2026-07-01 11:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-30 14:07 [PATCH 1/3] classes/insane: increase shebang size limit Ross Burton
2026-06-30 14:07 ` [PATCH 2/3] classes/insane: create one CachedPath instance in qa_check_staged Ross Burton
2026-06-30 14:08 ` [PATCH 3/3] classes/insane: clean up do_qa_sysroot Ross Burton
2026-07-01 6:01 ` [OE-core] [PATCH 1/3] classes/insane: increase shebang size limit Jörg Sommer
2026-07-01 11:28 ` Mathieu Dubois-Briand [this message]
2026-07-01 12:49 ` Ross Burton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DJN76GVF0HS6.3OSE79EMVNASR@bootlin.com \
--to=mathieu.dubois-briand@bootlin.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox