Openembedded Core Discussions
 help / color / mirror / Atom feed
From: "Mathieu Dubois-Briand" <mathieu.dubois-briand@bootlin.com>
To: <JPEWhacker@gmail.com>, <openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core][PATCH] licences: Move exceptions to subdirectory
Date: Wed, 19 Aug 2026 16:32:57 +0200	[thread overview]
Message-ID: <DKSZSLHAIC87.T4Z052L890U2@bootlin.com> (raw)
In-Reply-To: <20260818221721.3820389-1-JPEWhacker@gmail.com>

On Wed Aug 19, 2026 at 12:17 AM CEST, Joshua Watt via lists.openembedded.org wrote:
> Moves the SPDX license exceptions to a subdirectory to make the easier
> to identify as license exceptions vs. actual licenses
>
> This should have no effect on other layers since SPDX doesn't allow
> custom Exceptions like it does for Licenses (via LicenseRef-); since we
> have already enumerated all known exceptions, its unlikely any other
> layer have added their own
>
> Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
> ---

Hi Joshua,

Thanks for your patch.

It looks like this is breaking devtool/recipetool:

Traceback (most recent call last):
  File "/srv/pokybuild/yocto-worker/qemux86/build/layers/openembedded-core/meta/lib/oeqa/sdkext/cases/devtool.py", line 59, in test_devtool_add_reset
    self._run('devtool add myapp %s' % self.myapp_dst)
  File "/srv/pokybuild/yocto-worker/qemux86/build/layers/openembedded-core/meta/lib/oeqa/sdkext/case.py", line 22, in _run
    return subprocess.check_output(". %s > /dev/null;"\
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib64/python3.12/subprocess.py", line 466, in check_output
    return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib64/python3.12/subprocess.py", line 571, in run
    raise CalledProcessError(retcode, process.args,
oeqa.utils.subprocesstweak.OETestCalledProcessError: Command '. /srv/pokybuild/yocto-worker/qemux86/build/build/tmp/work/qemux86-poky-linux/core-image-minimal/1.0/testsdkext/environment-setup-core2-32-poky-linux > /dev/null; devtool add myapp /srv/pokybuild/yocto-worker/qemux86/build/build/tmp/work/qemux86-poky-linux/core-image-minimal/1.0/testsdkext/myapp;' returned non-zero exit status 1.
Standard Output: NOTE: Reconnecting to bitbake server...
NOTE: Reconnecting to bitbake server...
Traceback (most recent call last):
  File "/srv/pokybuild/yocto-worker/qemux86/build/build/tmp/work/qemux86-poky-linux/core-image-minimal/1.0/testsdkext/layers/openembedded-core/scripts/recipetool", line 111, in <module>
    ret = main()
  File "/srv/pokybuild/yocto-worker/qemux86/build/build/tmp/work/qemux86-poky-linux/core-image-minimal/1.0/testsdkext/layers/openembedded-core/scripts/recipetool", line 100, in main
    ret = args.func(args)
  File "/srv/pokybuild/yocto-worker/qemux86/build/build/tmp/work/qemux86-poky-linux/core-image-minimal/1.0/testsdkext/layers/openembedded-core/scripts/lib/recipetool/create.py", line 798, in create_recipe
    handle_license_vars(srctree_use, lines_before, handled, extravalues, tinfoil.config_data)
    ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/srv/pokybuild/yocto-worker/qemux86/build/build/tmp/work/qemux86-poky-linux/core-image-minimal/1.0/testsdkext/layers/openembedded-core/scripts/lib/recipetool/create.py", line 965, in handle_license_vars
    for node, licfile, md5 in find_licenses(srctree, d):
                              ~~~~~~~~~~~~~^^^^^^^^^^^^
  File "/srv/pokybuild/yocto-worker/qemux86/build/build/tmp/work/qemux86-poky-linux/core-image-minimal/1.0/testsdkext/layers/openembedded-core/meta/lib/oe/license_finder.py", line 201, in find_licenses
    licenses = match_licenses(licfiles, srctree, d, extra_hashes)
  File "/srv/pokybuild/yocto-worker/qemux86/build/build/tmp/work/qemux86-poky-linux/core-image-minimal/1.0/testsdkext/layers/openembedded-core/meta/lib/oe/license_finder.py", line 173, in match_licenses
    md5sums.update(_crunch_known_licenses(d))
                   ~~~~~~~~~~~~~~~~~~~~~~^^^
  File "/srv/pokybuild/yocto-worker/qemux86/build/build/tmp/work/qemux86-poky-linux/core-image-minimal/1.0/testsdkext/layers/openembedded-core/meta/lib/oe/license_finder.py", line 52, in _crunch_known_licenses
    md5value = bb.utils.md5_file(path)
  File "/srv/pokybuild/yocto-worker/qemux86/build/build/tmp/work/qemux86-poky-linux/core-image-minimal/1.0/testsdkext/layers/openembedded-core/bitbake/lib/bb/utils.py", line 648, in md5_file
    return _hasher(sig, filename)
  File "/srv/pokybuild/yocto-worker/qemux86/build/build/tmp/work/qemux86-poky-linux/core-image-minimal/1.0/testsdkext/layers/openembedded-core/bitbake/lib/bb/utils.py", line 623, in _hasher
    with open(filename, "rb") as f:
         ~~~~^^^^^^^^^^^^^^^^
IsADirectoryError: [Errno 21] Is a directory: '/srv/pokybuild/yocto-worker/qemux86/build/build/tmp/work/qemux86-poky-linux/core-image-minimal/1.0/testsdkext/layers/openembedded-core/meta/files/common-licenses/exceptions'

https://autobuilder.yoctoproject.org/valkyrie/#/builders/30/builds/4408
https://autobuilder.yoctoproject.org/valkyrie/#/builders/16/builds/4463
https://autobuilder.yoctoproject.org/valkyrie/#/builders/36/builds/4420
https://autobuilder.yoctoproject.org/valkyrie/#/builders/45/builds/2154
https://autobuilder.yoctoproject.org/valkyrie/#/builders/68/builds/4537

Everything else looks fine here. Can you have a look at that?

Thanks,
Mathieu

-- 
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com



  reply	other threads:[~2026-08-19 14:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-18 22:17 [OE-core][PATCH] licences: Move exceptions to subdirectory Joshua Watt
2026-08-19 14:32 ` Mathieu Dubois-Briand [this message]
2026-08-19 14:34   ` Joshua Watt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DKSZSLHAIC87.T4Z052L890U2@bootlin.com \
    --to=mathieu.dubois-briand@bootlin.com \
    --cc=JPEWhacker@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox