Openembedded Core Discussions
 help / color / mirror / Atom feed
From: "Yoann Congal" <yoann.congal@smile.fr>
To: <hfranco@baylibre.com>, <openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [scarthgap][PATCH] improve_kernel_cve_report: fix crash on entries without detail
Date: Thu, 10 Sep 2026 17:39:31 +0200	[thread overview]
Message-ID: <DLBQZJYT26YH.23YA0N3PX5036@smile.fr> (raw)
In-Reply-To: <20260901-fix-kernel-cve-scarthgap-v1-1-405f5d7a8957@baylibre.com>

On Tue Sep 1, 2026 at 9:42 PM CEST, Hiago De Franco via lists.openembedded.org wrote:
> When the CNA reports Unpatched and the scan reports Patched, cve_update()
> reads cve_data[cve]['detail'] unguarded. cve-check only writes 'detail'
> for CVEs carrying a CVE_STATUS varflag, so an entry marked Patched by an
> NVD version comparison has no such key and the script aborts with
> KeyError: 'detail' on ordinary cve-check output. The unhandled-update
> warning below makes the same assumption.
>
> Use .get() in both places. A missing detail falls through to the CNA
> verdict, and only an explicit CVE_STATUS = "backported-patch" outranks
> it, which is what the guard was added for.
>
> Tested by calling cve_update() with a Patched entry carrying no detail:
> before it raises KeyError, after it takes the CNA's Unpatched verdict,
> while an entry with detail = "backported-patch" stays Patched either way.
>
> AI-Generated: Uses Claude (claude-opus-5)
> Fixes: d317e2a52bd2 ("improve_kernel_cve_report: do not override backported-patch")
> Signed-off-by: Hiago De Franco <hfranco@baylibre.com>
> ---
>  scripts/contrib/improve_kernel_cve_report.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Hello,

If I'm not mistaken, this patch is the squash of 80ff4903ea1 and
f5da16b0d3c. I'd rather have 2 clean cherry-picks, this make tracking
which patch is needed or not easier.

Can you send the 2 cherry-picks as a series?

Thanks!
-- 
Yoann Congal
Smile ECS



  reply	other threads:[~2026-09-10 15:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-01 19:42 [scarthgap][PATCH] improve_kernel_cve_report: fix crash on entries without detail Hiago De Franco
2026-09-10 15:39 ` Yoann Congal [this message]
2026-09-11 13:26   ` [OE-core] " Hiago De Franco

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DLBQZJYT26YH.23YA0N3PX5036@smile.fr \
    --to=yoann.congal@smile.fr \
    --cc=hfranco@baylibre.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox