Openembedded Core Discussions
 help / color / mirror / Atom feed
From: "Yoann Congal" <yoann.congal@smile.fr>
To: "Tatrai, Peter" <peter.tatrai.ext@siemens.com>,
	"openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [scarthgap][PATCH v2] testimage: avoid symlinking missing qemu boot log
Date: Mon, 14 Sep 2026 16:02:28 +0200	[thread overview]
Message-ID: <DLF3FF58P4TN.2CQBWW4U3MHIO@smile.fr> (raw)
In-Reply-To: <AM0PR10MB3570E8E68B19FAFE5DBD942BDBBB2@AM0PR10MB3570.EURPRD10.PROD.OUTLOOK.COM>

On Mon Sep 14, 2026 at 11:03 AM CEST, Peter Tatrai wrote:
> Hello Yoann,
>
>> Where does this FileNotFoundError happen in scarthgap?
>> os.symlink() has no problem creating a symlink to a non existing file and I don't see
>> where we would open bootlog (we do open bootlog in wrynose/master though). Are
>> you sure we need this fix on scarthgap? Or maybe we need something else?
>
> You are right, thanks for catching that.
>
> In scarthgap this does not fail in os.symlink() itself: it creates a
> dangling symlink when the base bootlog is missing. The FileNotFoundError
> then happens later in our CI pipeline when collecting/copying the oeqa
> log artifacts.
>
> So, the issue is narrower than the v2 commit message says: the patch
> avoids creating a misleading dangling bootlog symlink in the result log
> directory. If that still sounds acceptable for scarthgap, I can send a
> v3 with the commit message updated accordingly and without implying that
> testimage itself raises FileNotFoundError.

Yes, I would take that :)

Thanks!

>
> Regards,
> Peter


-- 
Yoann Congal
Smile ECS



      reply	other threads:[~2026-09-14 14:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-25 12:56 [scarthgap][PATCH] testimage: avoid symlinking missing qemu boot log P. Tatrai
2026-09-05 22:29 ` [OE-core] " Yoann Congal
2026-09-07 18:57   ` Tatrai, Peter
2026-09-07 18:51 ` [scarthgap][PATCH v2] " P. Tatrai
2026-09-11 12:32   ` [OE-core] " Yoann Congal
2026-09-14  9:03     ` Tatrai, Peter
2026-09-14 14:02       ` Yoann Congal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DLF3FF58P4TN.2CQBWW4U3MHIO@smile.fr \
    --to=yoann.congal@smile.fr \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=peter.tatrai.ext@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox