From: "Mathieu Dubois-Briand" <mathieu.dubois-briand@bootlin.com>
To: <HimaniRamesh.Barde@windriver.com>,
<openembedded-core@lists.openembedded.org>
Cc: "Randy MacLeod" <Randy.MacLeod@windriver.com>,
"Shiva Komati" <Shiva.Komati@windriver.com>
Subject: Re: [OE-core] [PATCH v3] tiff: add ptest support
Date: Sun, 27 Sep 2026 09:32:14 +0200 [thread overview]
Message-ID: <DLPX9PXZH64F.1NP6JA01V1H00@bootlin.com> (raw)
In-Reply-To: <20260925080552.4144665-1-HimaniRamesh.Barde@windriver.com>
On Fri Sep 25, 2026 at 10:05 AM CEST, Himani Ramesh Barde via lists.openembedded.org wrote:
> Run the libtiff test suite as a ptest: the C unit tests (the automake
> check_PROGRAMS) and the shell tests that drive the tiff command-line tools.
>
> do_compile_ptest builds the test programs. do_install_ptest installs the
> binaries, the shell scripts, the common.sh helper, and the images/ and
> refs/ data, and points common.sh at the installed tools in ${bindir}
> instead of the build tree. The recipe lists the C programs once, in
> TIFF_PTEST_PROGS, and fills that list into run-ptest at install time.
>
> One test, test_ifd_loop_detection, opened its images through a build-time
> path instead of relative to the current directory, so it failed once
> installed. A small upstream patch makes it read the images from ".", like
> the other tests, so it now passes on every architecture.
>
> run-ptest prints automake-style PASS/FAIL/SKIP lines. Two tests skip in the
> default configuration:
>
> - the JBIG test, because jbig is not in the default PACKAGECONFIG
> - the thumbnail test, because the thumbnail tool is not built
>
> Registered under PTESTS_SLOW in ptest-packagelists.inc; the suite runs in
> about 30s on qemux86-64.
>
> Validated on qemux86-64:
>
> - 17 C unit tests pass
> - 85 shell tests pass
> - 2 skip (jbig, thumbnail)
> - 0 fail
>
> Signed-off-by: Himani Ramesh Barde <HimaniRamesh.Barde@windriver.com>
> ---
Hi Himani Ramesh,
Thanks for the new version. It looks like the embedded patch fails to
apply here:
ERROR: tiff-4.7.2-r0 do_patch: QA Issue: Fuzz detected:
Applying patch test_ifd_loop_detection-relative-images.patch
patching file test/test_ifd_loop_detection.c
Hunk #1 succeeded at 45 with fuzz 2 (offset 11 lines).
https://autobuilder.yoctoproject.org/valkyrie/#/builders/4/builds/4740
Can you have a look at the issue?
Thanks,
Mathieu
--
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2026-09-27 7:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260921100952.2619282-1-HimaniRamesh.Barde@windriver.com>
2026-09-25 8:05 ` [PATCH v3] tiff: add ptest support Himani Ramesh Barde
2026-09-27 7:32 ` Mathieu Dubois-Briand [this message]
2026-09-30 7:34 ` [PATCH v4] " Himani Ramesh Barde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DLPX9PXZH64F.1NP6JA01V1H00@bootlin.com \
--to=mathieu.dubois-briand@bootlin.com \
--cc=HimaniRamesh.Barde@windriver.com \
--cc=Randy.MacLeod@windriver.com \
--cc=Shiva.Komati@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox