Openembedded Core Discussions
 help / color / mirror / Atom feed
From: "Gaël PORTAY" <gael.portay+rtone@gmail.com>
To: "Yoann Congal" <yoann.congal@smile.fr>,
	<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [scarthgap][PATCH] connman: fix syslog identity with glibc
Date: Tue, 13 Oct 2026 07:24:38 +0200	[thread overview]
Message-ID: <DM3GKQKJ8VE0.1XOVP37F28VC4@gmail.com> (raw)
In-Reply-To: <DLUGAJL0DW01.2UDQ8P6GXPBUN@smile.fr>

Hello Yoann,

On Fri Oct 2, 2026 at 5:17 PM CEST, Yoann Congal wrote:
> Hello,
>
> On Tue Sep 29, 2026 at 11:30 AM CEST, Gaël PORTAY via lists.openembedded.org wrote:
> > The connman syslog patch modifies the handling of the ident string to
> > solve a build issue with musl.
> What "connman syslog patch"?
> I'm having a hard time understanding this patch...
>

I am sorry to hear that.

By "connman syslog pach", I wanted to reference that downstream change:

	0001-src-log.c-Include-libgen.h-for-basename-API.patch

I can reword the commit message if it is unclear; or I can remove some
parts of it that bring some unnecessary noise.

> > (...)
> >
> > This removes 0001-src-log.c-Include-libgen.h-for-basename-API.patch[4]
> > from the SRC_URI if libc-glibc overrides so that it is not applied when
> > using glibc.
>
> Hmm, this patch moves "0001-vpn-Adding-support-for-latest-pppd-2.5.0-release.patch"
> not 0001-src-log.c-Include-libgen.h-for-basename-API.patch"
>

Oops, I made a terrible mistake; let me respin a v2 to fix this.

Note that I have that following change in a .bbappend; this would
explain why I have not figured it out :facepalm:

	SRC_URI:remove:libc-glibc = "file://0001-src-log.c-Include-libgen.h-for-basename-API.patch"

Again, I am sorry for that mistake; and I will retest it correctly later
this day.

> > (...)
> > 
> > This fixes commit 992d59564b84333740e6465ec696238274b73938.
> Where it this commit from? I can't find it in oe-core nor poky.
>

This is weird, it comes from poky tree: 992d59564b (connman: Fix build
with musl). And you are right, it is not part of oe-core.

Nevermind, I wanted to link this change in poky tree:
https://git.yoctoproject.org/poky/commit/?id=992d59564b84333740e6465ec696238274b73938

Or that one in oe-core tree:
https://git.openembedded.org/openembedded-core/commit/?id=d0139bcbe0499e570f02f8f7b7e364763f7359ec

> > (...)
> > diff --git a/meta/recipes-connectivity/connman/connman_1.42.bb b/meta/recipes-connectivity/connman/connman_1.42.bb
> > index 9b3abbe258..5c8bdd43f2 100644
> > --- a/meta/recipes-connectivity/connman/connman_1.42.bb
> > +++ b/meta/recipes-connectivity/connman/connman_1.42.bb
> > @@ -5,13 +5,14 @@ SRC_URI = "${KERNELORG_MIRROR}/linux/network/${BPN}/${BP}.tar.xz \
> >             file://0001-connman.service-stop-systemd-resolved-when-we-use-co.patch \
> >             file://connman \
> >             file://no-version-scripts.patch \
> > -           file://0001-vpn-Adding-support-for-latest-pppd-2.5.0-release.patch \
> >             file://0001-src-log.c-Include-libgen.h-for-basename-API.patch \
> >             file://CVE-2025-32743.patch \
> >             file://CVE-2025-32366.patch \
> >             "
> >  
> > -SRC_URI:append:libc-musl = " file://0002-resolve-musl-does-not-implement-res_ninit.patch"
> > +SRC_URI:append:libc-musl = " file://0001-vpn-Adding-support-for-latest-pppd-2.5.0-release.patch \
> > +                             file://0002-resolve-musl-does-not-implement-res_ninit.patch \
> > +                           "
> >  
> >  SRC_URI[sha256sum] = "a3e6bae46fc081ef2e9dae3caa4f7649de892c3de622c20283ac0ca81423c2aa"

Here is what the change would look like:

	@@ -6,12 +6,13 @@ SRC_URI = "${KERNELORG_MIRROR}/linux/network/${BPN}/${BP}.tar.xz \
	            file://connman \
	            file://no-version-scripts.patch \
	            file://0001-vpn-Adding-support-for-latest-pppd-2.5.0-release.patch \
	-           file://0001-src-log.c-Include-libgen.h-for-basename-API.patch \
	            file://CVE-2025-32743.patch \
	            file://CVE-2025-32366.patch \
	            "
	
	-SRC_URI:append:libc-musl = " file://0002-resolve-musl-does-not-implement-res_ninit.patch"
	+SRC_URI:append:libc-musl = " file://0001-src-log.c-Include-libgen.h-for-basename-API.patch \
	+                             file://0002-resolve-musl-does-not-implement-res_ninit.patch \
	+                           "
	
	 SRC_URI[sha256sum] = "a3e6bae46fc081ef2e9dae3caa4f7649de892c3de622c20283ac0ca81423c2aa" 
	
>
> Regards,

Regards,
Gaël


  reply	other threads:[~2026-10-13  5:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-29  9:30 [scarthgap][PATCH] connman: fix syslog identity with glibc Gaël PORTAY
2026-10-02 15:17 ` [OE-core] " Yoann Congal
2026-10-13  5:24   ` Gaël PORTAY [this message]
2026-10-13  7:07     ` Yoann Congal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM3GKQKJ8VE0.1XOVP37F28VC4@gmail.com \
    --to=gael.portay+rtone@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=yoann.congal@smile.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox