Openembedded Core Discussions
 help / color / mirror / Atom feed
From: "Mathieu Dubois-Briand" <mathieu.dubois-briand@bootlin.com>
To: <adam.duskett@amarulasolutions.com>,
	<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH v10 2/3] dnf: Upgrade to 5.4.6.0
Date: Fri, 16 Oct 2026 15:14:46 +0200	[thread overview]
Message-ID: <DM6AGBWU09J7.1BJCW1KEXDAOL@bootlin.com> (raw)
In-Reply-To: <20261015142331.3639101-2-adam.duskett@amarulasolutions.com>

On Thu Oct 15, 2026 at 4:23 PM CEST, Adam Duskett via lists.openembedded.org wrote:
> Completely rewritten in C++, there are several changes needed
> to facilitate moving from DNF4 to DNF5. Below are some significant
> items to note:
>
>     - Added a negative lookahead filter for the following warning if
>       RPM_SIGN_PACKAGES != '1': "Warning: skipped OpenPGP checks"
>       This warning is hard-coded and piped to stderr if gpg checks
>       are disabled. However, most users do not sign their RPM packages
>       and use dnf to simply construct the rootfs.
>
>     - The "-v/--verbose" cli option is removed. As such, remove the argument
>     everywhere it was called.[1]
>
>     - the rpmverbosity cli option is replaced with --setopt=rpmverbosity
>
>     - Change gpgcheck to pkg_gpgcheck as this is what the documentation
>     recommends.[2]
>
>     - --nogpgcheck is now --no-gpgchecks
>
>     - --setopt=protect_running_kernel=False has to be set or else every dnf
>     transaction complains that /boot/vmlinuz-${kernel_version} does not
>     exist in /var/log/dnf5.log. There is an open issue on github[3] to enable
>     the currently not-yet implemented `autocheck_running_kernel option`, but
>     it has been open for quite some time and the protect_running_kernel
>     option supresses the message.
>
>     - Move --skip-broken to after the install argument as the global
>       --skip-broken argument is removed.
>
>     - /var/cache/dnf is replaced with /var/cache/libdnf5
>
>     - Add `features += 'PACKAGECONFIG:append:pn-rpm = " sequoia"\n'`
>           `features += 'PACKAGECONFIG:append:pn-librepo = " sequoia"\n'`
>       to test_testimage_dnf as librepo currently does not work
>       with gpgme.
>
>     - Change `if line.startswith("Error in POSTIN scriptlet in rpm package"):`
>       to `if "Error in %post scriptlet:" in line:` as dnf prints `>>>`
>       charachters and the error string has changed.
>
> While DNF5 has many config options, unfortunately, the majority
> of them depends on sdbus-c++, which is not included in OE-core.
> However, the package is included in meta-openembedded, so it's
> best to include the PACKAGECONFIG options in the recipe and
> leave them off by default.
>
> 1: https://github.com/rpm-software-management/dnf5/issues/464
> 2: https://dnf5.readthedocs.io/en/latest/dnf5.conf.5.html
> 3: https://github.com/rpm-software-management/dnf5/issues/1255
>
> Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com>
> ---

Err, I believe this is also breaking libtoml build. I'm not sure to
really get how:

ERROR: libtoml11-1_4.4.0-r0 do_compile: Execution of '/srv/pokybuild/yocto-worker/qemuarm-oecore/build/build/tmp/work/cortexa15t2hf-neon-oe-linux-gnueabi/libtoml11/4.4.0/temp/run.do_compile.836786' failed with exit code 1
ERROR: Logfile of failure stored in: /srv/pokybuild/yocto-worker/qemuarm-oecore/build/build/tmp/work/cortexa15t2hf-neon-oe-linux-gnueabi/libtoml11/4.4.0/temp/log.do_compile.836786
...
| FAILED: [code=1] tests/CMakeFiles/test_value.dir/test_value.cpp.o
| /srv/pokybuild/yocto-worker/qemuarm-oecore/build/build/tmp/work/cortexa15t2hf-neon-oe-linux-gnueabi/libtoml11/4.4.0/recipe-sysroot-native/usr/bin/arm-oe-linux-gnueabi/arm-oe-linux-gnueabi-g++ --sysroot=/srv/pokybuild/yocto-worker/qemuarm-oecore/build/build/tmp/work/cortexa15t2hf-neon-oe-linux-gnueabi/libtoml11/4.4.0/recipe-sysroot -DTOML11_COMPILE_SOURCES -I/srv/pokybuild/yocto-worker/qemuarm-oecore/build/build/tmp/work/cortexa15t2hf-neon-oe-linux-gnueabi/libtoml11/4.4.0/sources/libtoml11-4.4.0/tests/extlib/doctest/doctest -I/srv/pokybuild/yocto-worker/qemuarm-oecore/build/build/tmp/work/cortexa15t2hf-neon-oe-linux-gnueabi/libtoml11/4.4.0/sources/libtoml11-4.4.0/include -mthumb -mfpu=neon -mfloat-abi=hard -mcpu=cortex-a15 -D_TIME_BITS=64 -D_FILE_OFFSET_BITS=64 -fstack-protector-strong  -O2 -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Werror=format-security  --sysroot=/srv/pokybuild/yocto-worker/qemuarm-oecore/build/build/tmp/work/cortexa15t2hf-neon-oe-linux-gnueabi/libtoml11/4.4.0/recipe-sysroot  -O2 -g -fcanon-prefix-map  -ffile-prefix-map=/srv/pokybuild/yocto-worker/qemuarm-oecore/build/build/tmp/work/cortexa15t2hf-neon-oe-linux-gnueabi/libtoml11/4.4.0/sources/libtoml11-4.4.0=/usr/src/debug/libtoml11/4.4.0  -ffile-prefix-map=/srv/pokybuild/yocto-worker/qemuarm-oecore/build/build/tmp/work/cortexa15t2hf-neon-oe-linux-gnueabi/libtoml11/4.4.0/build=/usr/src/debug/libtoml11/4.4.0  -ffile-prefix-map=/srv/pokybuild/yocto-worker/qemuarm-oecore/build/build/tmp/work/cortexa15t2hf-neon-oe-linux-gnueabi/libtoml11/4.4.0/recipe-sysroot=  -ffile-prefix-map=/srv/pokybuild/yocto-worker/qemuarm-oecore/build/build/tmp/work/cortexa15t2hf-neon-oe-linux-gnueabi/libtoml11/4.4.0/recipe-sysroot-native=  -pipe -fvisibility-inlines-hidden -std=c++11 -Wall -Wextra -Wpedantic -Werror -Wsign-conversion -Wconversion -Wduplicated-cond -Wduplicated-branches -Wlogical-op -Wdouble-promotion -Wundef -Wshadow -MD -MT tests/CMakeFiles/test_value.dir/test_value.cpp.o -MF tests/CMakeFiles/test_value.dir/test_value.cpp.o.d -o tests/CMakeFiles/test_value.dir/test_value.cpp.o -c /srv/pokybuild/yocto-worker/qemuarm-oecore/build/build/tmp/work/cortexa15t2hf-neon-oe-linux-gnueabi/libtoml11/4.4.0/sources/libtoml11-4.4.0/tests/test_value.cpp
| In file included from /srv/pokybuild/yocto-worker/qemuarm-oecore/build/build/tmp/work/cortexa15t2hf-neon-oe-linux-gnueabi/libtoml11/4.4.0/sources/libtoml11-4.4.0/include/toml11/types.hpp:9,
|                  from /srv/pokybuild/yocto-worker/qemuarm-oecore/build/build/tmp/work/cortexa15t2hf-neon-oe-linux-gnueabi/libtoml11/4.4.0/sources/libtoml11-4.4.0/include/toml11/skip.hpp:8,
|                  from /srv/pokybuild/yocto-worker/qemuarm-oecore/build/build/tmp/work/cortexa15t2hf-neon-oe-linux-gnueabi/libtoml11/4.4.0/sources/libtoml11-4.4.0/include/toml11/parser.hpp:10,
|                  from /srv/pokybuild/yocto-worker/qemuarm-oecore/build/build/tmp/work/cortexa15t2hf-neon-oe-linux-gnueabi/libtoml11/4.4.0/sources/libtoml11-4.4.0/tests/utility.hpp:6,
|                  from /srv/pokybuild/yocto-worker/qemuarm-oecore/build/build/tmp/work/cortexa15t2hf-neon-oe-linux-gnueabi/libtoml11/4.4.0/sources/libtoml11-4.4.0/tests/test_value.cpp:4:
| In member function 'toml::basic_value<TypeConcig>& toml::basic_value<TypeConcig>::operator=(const std::chrono::duration<_Rep, _Period>&) [with Rep = long long int; Period = std::ratio<3600>; TypeConfig = toml::type_config]',
|     inlined from 'void test_ctors(T, U, FMT) [with toml::value_t TYPE = toml::value_t::local_time; T = std::chrono::duration<long long int, std::ratio<3600> >; U = std::chrono::duration<long long int>; FMT = toml::local_time_format_info]' at /srv/pokybuild/yocto-worker/qemuarm-oecore/build/build/tmp/work/cortexa15t2hf-neon-oe-linux-gnueabi/libtoml11/4.4.0/sources/libtoml11-4.4.0/tests/test_value.cpp:303:33:
| /srv/pokybuild/yocto-worker/qemuarm-oecore/build/build/tmp/work/cortexa15t2hf-neon-oe-linux-gnueabi/libtoml11/4.4.0/sources/libtoml11-4.4.0/include/toml11/value.hpp:905:13: error: '((unsigned char*)((char*)&x_assign_different_type + offsetof(toml::value, toml::basic_value<toml::type_config>::<unnamed>)))[12]' may be used uninitialized [-Werror=maybe-uninitialized]
|   905 |             fmt = this->as_local_time_fmt();
|       |             ^~~
| /srv/pokybuild/yocto-worker/qemuarm-oecore/build/build/tmp/work/cortexa15t2hf-neon-oe-linux-gnueabi/libtoml11/4.4.0/sources/libtoml11-4.4.0/tests/test_value.cpp: In function 'void test_ctors(T, U, FMT) [with toml::value_t TYPE = toml::value_t::local_time; T = std::chrono::duration<long long int, std::ratio<3600> >; U = std::chrono::duration<long long int>; FMT = toml::local_time_format_info]':
| /srv/pokybuild/yocto-worker/qemuarm-oecore/build/build/tmp/work/cortexa15t2hf-neon-oe-linux-gnueabi/libtoml11/4.4.0/sources/libtoml11-4.4.0/tests/test_value.cpp:302:21: note: 'x_assign_different_type' declared here
|   302 |         toml::value x_assign_different_type(true);
|       |                     ^~~~~~~~~~~~~~~~~~~~~~~

https://autobuilder.yoctoproject.org/valkyrie/#/builders/40/builds/4814
https://autobuilder.yoctoproject.org/valkyrie/#/builders/16/builds/4874

I only saw that on arm 32 bits right now.

Can you have a look at it?

Thanks,
Mathieu

-- 
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com



  parent reply	other threads:[~2026-10-16 13:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-15 14:23 [PATCH v10 1/3] rpm: add 0017-critically-fail-if-post-install-fails.patch Adam Duskett
2026-10-15 14:23 ` [PATCH v10 2/3] dnf: Upgrade to 5.4.6.0 Adam Duskett
2026-10-16 11:56   ` [OE-core] " Mathieu Dubois-Briand
2026-10-16 13:14   ` Mathieu Dubois-Briand [this message]
2026-10-15 14:23 ` [PATCH v10 3/3] libdnf: remove recipe Adam Duskett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6AGBWU09J7.1BJCW1KEXDAOL@bootlin.com \
    --to=mathieu.dubois-briand@bootlin.com \
    --cc=adam.duskett@amarulasolutions.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox