From: "Mathieu Dubois-Briand" <mathieu.dubois-briand@bootlin.com>
To: <ricardo.salveti@oss.qualcomm.com>,
<openembedded-core@lists.openembedded.org>
Cc: <jose.quaresma@oss.qualcomm.com>
Subject: Re: [OE-core] [PATCH] checklayer: run bitbake once per machine for the machine tests
Date: Wed, 21 Oct 2026 15:47:36 +0200 [thread overview]
Message-ID: <DMAKA726B8DQ.1SSH36F5YORHM@bootlin.com> (raw)
In-Reply-To: <20261020223910.539165-1-ricardo.salveti@oss.qualcomm.com>
On Wed Oct 21, 2026 at 12:39 AM CEST, Ricardo Salveti via lists.openembedded.org wrote:
> With --machines, test_machine_signatures and test_machine_world each
> run "bitbake -S lockedsigs world" for every machine, with and without
> -k. When world can be built, -k makes no difference and both runs give
> the same signatures, so bitbake runs twice per machine for nothing. On
> meta-qcom, which tests 24 machines, these two tests take 1665 s of the
> 1818 s of the check.
>
> Cache the outcome of the run without -k on the test context, which is
> created for every tested layer, so that whichever test comes first runs
> bitbake and the other one reuses the result. When world can't be built,
> test_machine_signatures still runs bitbake again with -k for the
> signatures: get_signatures(failsafe=True) ignores the error of that
> run, which test_machine_world needs, so one -k run can't serve both
> tests. test_world and test_signatures have the same duplication without
> a machine; that is left for a separate change.
>
> Tested on meta-qcom (127450527f) with 16 bitbake threads, time in the
> two tests: 24 machines 1664.8 s -> 969.9 s, three machines 229.9 s ->
> 140.5 s, with the same results and logs. Adding a machine that breaks
> world, one with different zlib CFLAGS or one that doesn't parse to the
> three machines gives the same verdicts and errors as before.
>
> AI-Generated: Uses Claude Code (Claude Opus 5.5)
> Signed-off-by: Ricardo Salveti <ricardo.salveti@oss.qualcomm.com>
> ---
Hi Ricardo,
Thanks for your patch.
I can see it conflicts with the patch from Otavio Salvador sent a few
days ago. I believe part of the points addressed by both patches are
similar. Any thought on that?
https://lore.kernel.org/openembedded-core/20261019143924.1521981-4-otavio@ossystems.com.br/
Thanks,
Mathieu
--
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2026-10-21 13:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-20 22:39 [PATCH] checklayer: run bitbake once per machine for the machine tests Ricardo Salveti
2026-10-21 13:47 ` Mathieu Dubois-Briand [this message]
2026-10-21 17:23 ` [OE-core] " Ricardo Salveti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DMAKA726B8DQ.1SSH36F5YORHM@bootlin.com \
--to=mathieu.dubois-briand@bootlin.com \
--cc=jose.quaresma@oss.qualcomm.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=ricardo.salveti@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox