From: "Yoann Congal" <yoann.congal@smile.fr>
To: "Jinwang Li" <jinwang.li@oss.qualcomm.com>,
<openembedded-core@lists.openembedded.org>
Cc: <cheng.jiang@oss.qualcomm.com>, <quic_chezhou@quicinc.com>,
<wei.deng@oss.qualcomm.com>, <shuai.zhang@oss.qualcomm.com>,
<mengshi.wu@oss.qualcomm.com>, <xiuzhuo.shang@oss.qualcomm.com>
Subject: Re: [wrynose][PATCH v2 5/5] bluez5: Fix u128_to_string skipping data[4]
Date: Mon, 09 Nov 2026 11:59:32 +0100 [thread overview]
Message-ID: <DMQMLV305GEM.1SFJXBWCASXVH@smile.fr> (raw)
In-Reply-To: <20261021100829.2460593-6-jinwang.li@oss.qualcomm.com>
On Wed Oct 21, 2026 at 12:08 PM CEST, Jinwang Li wrote:
> data[3] was used twice, skipping data[4] in the output string.
>
> Signed-off-by: Jinwang Li <jinwang.li@oss.qualcomm.com>
> ---
> meta/recipes-connectivity/bluez5/bluez5.inc | 1 +
> ...p-Fix-u128_to_string-skipping-data-4.patch | 33 +++++++++++++++++++
> 2 files changed, 34 insertions(+)
> create mode 100644 meta/recipes-connectivity/bluez5/bluez5/0001-obexd-pbap-Fix-u128_to_string-skipping-data-4.patch
>
> diff --git a/meta/recipes-connectivity/bluez5/bluez5.inc b/meta/recipes-connectivity/bluez5/bluez5.inc
> index db650acdd0..75d76cf96d 100644
> --- a/meta/recipes-connectivity/bluez5/bluez5.inc
> +++ b/meta/recipes-connectivity/bluez5/bluez5.inc
> @@ -80,6 +80,7 @@ SRC_URI = "${KERNELORG_MIRROR}/linux/bluetooth/bluez-${PV}.tar.xz \
> file://0001-avdtp-Fix-GET_CONFIGURATION-cmd.patch \
> file://0001-avdtp-Return-correct-error-when-SEP-is-inuse.patch \
> file://0001-gobex-Fix-ABORT-response-being-discarded.patch \
> + file://0001-obexd-pbap-Fix-u128_to_string-skipping-data-4.patch \
> "
> S = "${UNPACKDIR}/bluez-${PV}"
Hello,
Nit: Review is easier if the stable commit title matches the commit on
master.
No need to make a new version for this though.
Thanks!
--
Yoann Congal
Smile ECS
prev parent reply other threads:[~2026-11-09 10:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-21 10:08 [wrynose][PATCH v2 0/5] bluez5: fix AVDTP and OBEX issues Jinwang Li
2026-10-21 10:08 ` [wrynose][PATCH v2 1/5] bluez5: Fix error handling for AVDTP_OPEN cmd Jinwang Li
2026-10-21 10:08 ` [wrynose][PATCH v2 2/5] bluez5: Fix GET_CONFIGURATION cmd Jinwang Li
2026-10-21 10:08 ` [wrynose][PATCH v2 3/5] bluez5: Return correct error when SEP is inuse Jinwang Li
2026-10-21 10:08 ` [wrynose][PATCH v2 4/5] bluez5: Fix ABORT response being discarded Jinwang Li
2026-10-21 10:08 ` [wrynose][PATCH v2 5/5] bluez5: Fix u128_to_string skipping data[4] Jinwang Li
2026-11-09 10:59 ` Yoann Congal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DMQMLV305GEM.1SFJXBWCASXVH@smile.fr \
--to=yoann.congal@smile.fr \
--cc=cheng.jiang@oss.qualcomm.com \
--cc=jinwang.li@oss.qualcomm.com \
--cc=mengshi.wu@oss.qualcomm.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=quic_chezhou@quicinc.com \
--cc=shuai.zhang@oss.qualcomm.com \
--cc=wei.deng@oss.qualcomm.com \
--cc=xiuzhuo.shang@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox