Re: [PATCH 3/3] powerpc: define TUNE_PKGARCH for powerpc/powerpc-nf

[Christopher Larson <kergoth@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1203 bytes --]

On Tuesday, March 27, 2012 at 2:50 PM, Mark Hatle wrote:
> On 3/27/12 4:05 PM, Chris Larson wrote:
> 
> 
> 
> 
> On PowerPC TUNE_PKGARCH should be set to powerpc (or overriden by the machines).
> On PowerPC64, it should be set to powerpc64. If this is not happening that is
> the bug, lack of the default TUNE_PKGARCH. (based on the original implementation.)


I don't think your point of view is covering all the issues. 

The default TUNE_PKGARCH is TUNE_PKGARCH_${TUNE_PKGARCH_tune-${DEFAULTTUNE}. If arch-powerpc.inc sets TUNE_PKGARCH directly, as it used to, then all the more specific tunings won't have their TUNE_PKGARCH_tune-<tune> obeyed, which was the behavior prior to my submitting a patch which removed the explicit TUNE_PKGARCH override in arch-powerpc.inc.

So we have two options. Either we override TUNE_PKGARCH directly in arch-powerpc.inc again, thereby making powerpc tune- files like tune-ppce500v2 not have their TUNE_PKGARCH_tune-<tune> obeyed (or those tune- files have to override TUNE_PKGARCH as well, which seems counter to the whole design of the tuning implementation), or we add TUNE_PKGARCH_tune-<tune> definitions for the generic tunings also.

-Chris

[-- Attachment #2: Type: text/html, Size: 2892 bytes --]