Re: [PATCH 00/17] musl fixes phase 2

[Khem Raj <raj.khem@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1695 bytes --]

Hi Ross

No worries, I will prepare phase3 today at earliest. Where these will be addressed along with new fixes.

Thanks
-Khem

> On Jan 7, 2016, at 7:32 AM, Burton, Ross <ross.burton@intel.com> wrote:
> 
> Hi Khem,
> 
> I just reviewed this series again and there's still some patches that need tweaking:
> 
> On 19 December 2015 at 23:52, Khem Raj <raj.khem@gmail.com <mailto:raj.khem@gmail.com>> wrote:
> Khem Raj (17):
>   powertop: Include right headers for timval struct
> 
> Missing Upstream-Status.
> 
>   dhcp: Include sys/types.h for u_int* defs
> 
> Missing Upstream-Status.
> 
>   blktrace: Include <sys/types.h for dev_t
> 
> Missing Upstream-Status (Status doesn't count, there's machinery about this tag now)
> 
>   fts: Add recipe
> 
> Every patch is missing patch explanation / signed-off-by / upstream-status.
> 
>   libcgroup: Add dependency on fts when building on musl
> 
> The U-S is Pending but the commit isn't from you - was this actually a backport or just a patch that eg buildroot is carrying?
> 
>   linux-libc-headers: Port patches for linux-headers for musl
> 
> Patches are missing signed-off-by.
> 
>   gdk-pixbuf: Fix latent build  issue exposed by musl
> 
> This is a test that uses glibc features, so simply changing it to use malloc isn't right.  This is already fixed upstream properly: https://git.gnome.org/browse/gdk-pixbuf/commit/tests/pixbuf-lowmem.c?id=205a3b04e1216c1df199aec95185f7f48b8e0491 <https://git.gnome.org/browse/gdk-pixbuf/commit/tests/pixbuf-lowmem.c?id=205a3b04e1216c1df199aec95185f7f48b8e0491>
> 
> The rest are merged into ross/mut so can you please rebase onto that.
> 
> Ross
> 
> 


[-- Attachment #1.2: Type: text/html, Size: 4515 bytes --]

[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]