From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 610A3EDA689 for ; Tue, 3 Mar 2026 15:22:49 +0000 (UTC) Subject: [scarthgap][PATCH] uboot-config: Fix devtool modify #scarthgap To: openembedded-core@lists.openembedded.org From: nicolas.heemeryck@devialet.com X-Originating-Location: FR (149.232.202.21) X-Originating-Platform: Linux Firefox 148 User-Agent: GROUPS.IO Web Poster MIME-Version: 1.0 Date: Tue, 03 Mar 2026 07:22:48 -0800 Message-ID: Content-Type: multipart/alternative; boundary="MmyoSeGuUQb7ObxEiUIa" List-Id: X-Webhook-Received: from 45-33-107-173.ip.linodeusercontent.com [45.33.107.173] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Tue, 03 Mar 2026 15:22:49 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/232320 --MmyoSeGuUQb7ObxEiUIa Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi all, Is this possible to cherry-pick the patch attached that fixes the u-boot de= vtool modify ? commit 371ecef31872a611f34b2541a50ceed0c3ce06af Author: Tom Hochstein Date: =C2=A0 Wed Feb 5 16:18:55 2025 -0600 uboot-config: Fix devtool modify Fix a problem with `devtool modify` as suggested by Marcus Flyckt on the mailing list: ``` I encountered an issue with `do_config` when using `devtool modify` on `u-boot-imx`. ``` [...] | cp: cannot stat '[...]/u-boot-imx/2024.04/build/imx8mp_wl400s_defconfig/.= config': No such file or directory | WARNING: exit code 1 from a shell command. ERROR: Task ([...]/sources/poky/../meta-freescale/recipes-bsp/u-boot/u-boot= -imx_2024.04.bb:do_configure) failed with exit code '1' NOTE: Tasks Summary: Attempted 963 tasks of which 962 didn't need to be rer= un and 1 failed. Summary: 1 task failed: [...]/sources/poky/../meta-freescale/recipes-bsp/u-boot/u-boot-imx_2024.04.= bb:do_configure Summary: There was 1 ERROR message, returning a non-zero exit code ``` The issue seems to originate from the following lines in `workspace/appends/u-boot-imx_2024.04.bbappend`: ``` do_configure:append() { if [ ${@oe.types.boolean(d.getVar("KCONFIG_CONFIG_ENABLE_MENUCONFIG"))} =3D= True ]; then cp ${KCONFIG_CONFIG_ROOTDIR}/.config ${S}/.config.baseline ln -sfT ${KCONFIG_CONFIG_ROOTDIR}/.config ${S}/.config.new fi } ``` For some reason `KCONFIG_CONFIG_ROOTDIR` does not point to the correct directory. It gets its value in `uboot-config.bbclass`: ``` if len(ubootconfig) =3D=3D 1: d.setVar('KCONFIG_CONFIG_ROOTDIR', os.path.join(d.getVar("B"), d.getVar("UB= OOT_MACHINE").strip())) ``` So the main issue is that B gets expanded in this expression, and then later B gets changed by `externalsrc.bbclass`. `d.getVar("B", False)` does not solve the issue, however the proposed change does. ``` - https://lists.yoctoproject.org/g/yocto/topic/109254298#msg64152] Fixes [YOCTO #15603] Suggested-by: Marcus Flyckt (From OE-Core rev: 57b21065a25100c31515b32fd7c77bde3355d684) Signed-off-by: Tom Hochstein Signed-off-by: Richard Purdie Best Regards, Nicolas --MmyoSeGuUQb7ObxEiUIa Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable
Hi all,
 
Is this possible to cherry-pick the patch attached that fixes the u-bo= ot devtool modify ?
 
commit 371ecef31872a611f34b2541a50ceed0c= 3ce06af
Author: Tom Hochstein <tom.hochstein@oss.nxp.com>
D= ate:   Wed Feb 5 16:18:55 2025 -0600
    uboot-config: Fix devtool = modify
    Fix a problem with `devtoo= l modify` as suggested by Marcus Flyckt on
    the mailing l= ist:
    ```
        I encountered = an issue with `do_config` when using `devtool modify`
    &n= bsp;   on `u-boot-imx`.
        ```
&nb= sp;       [...]
        | cp: canno= t stat '[...]/u-boot-imx/2024.04/build/imx8mp_wl400s_defconfig/.config': No= such file or directory
        | WARNING: exit co= de 1 from a shell command.
        ERROR: Task ([.= ..]/sources/poky/../meta-freescale/recipes-bsp/u-boot/u-boot-imx_2024.04.bb= :do_configure) failed with exit code '1'
        N= OTE: Tasks Summary: Attempted 963 tasks of which 962 didn't need to be reru= n and 1 failed.
        Summary: 1 task failed:          [...]/sources/poky/../meta-freescale/= recipes-bsp/u-boot/u-boot-imx_2024.04.bb:do_configure
    &n= bsp;   Summary: There was 1 ERROR message, returning a non-zero exit c= ode
        ```
        The issue se= ems to originate from the following lines in
      &nbs= p; `workspace/appends/u-boot-imx_2024.04.bbappend`:
        ```
&nb= sp;       do_configure:append() {
      =       if [ ${@oe.types.boolean(d.getVar("KCONFIG_CONFIG_ENAB= LE_MENUCONFIG"))} =3D True ]; then
          =       cp ${KCONFIG_CONFIG_ROOTDIR}/.config ${S}/.config.base= line
                ln -sfT $= {KCONFIG_CONFIG_ROOTDIR}/.config ${S}/.config.new
     =       fi
        }
  &nb= sp;     ```
        For some rea= son `KCONFIG_CONFIG_ROOTDIR` does not point to the
     = ;   correct directory. It gets its value in `uboot-config.bbclass`:
        ```
&nb= sp;       if len(ubootconfig) =3D=3D 1:
    &= nbsp;                   d.setV= ar('KCONFIG_CONFIG_ROOTDIR', os.path.join(d.getVar("B"), d.getVar("UBOOT_MA= CHINE").strip()))
        ```
        So the main = issue is that B gets expanded in this expression, and
    &n= bsp;   then later B gets changed by `externalsrc.bbclass`.
 =       `d.getVar("B", False)` does not solve the issue, howe= ver the
        proposed change does.
  =   ```
    - https://lists.yoctoproject.org/g/yocto/topi= c/109254298#msg64152]
    Fixes [YOCTO #15603]
    Suggested-by: Marcus Flyck= t <marcus.flyckt@gmail.com>
    (From OE-Core rev: 57b= 21065a25100c31515b32fd7c77bde3355d684)
    Signed-off-by: Tom Hochste= in <tom.hochstein@oss.nxp.com>
    Signed-off-by: Rich= ard Purdie <richard.purdie@linuxfoundation.org>
 
 
Best Regards,
Nicolas
--MmyoSeGuUQb7ObxEiUIa--