Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: Khem Raj <raj.khem@gmail.com>, openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH 6/6] pseudo: Disable LFS on 32bit arches
Date: Fri, 2 Dec 2022 00:05:35 +0100	[thread overview]
Message-ID: <Y4kzP3WMTabOHMYB@mail.local> (raw)
In-Reply-To: <e65f40a225318abefd91c75d51943fc141368082.camel@linuxfoundation.org>

On 01/12/2022 19:12:50+0000, Richard Purdie wrote:
> On Thu, 2022-12-01 at 11:02 -0800, Khem Raj wrote:
> > pseudo overrides certain libc functions which are aliases when LFS64 is
> > enabled. In anycase pseudo may not be much used on 32bit systems anyway
> > 
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > ---
> >  meta/recipes-devtools/pseudo/pseudo_git.bb | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/meta/recipes-devtools/pseudo/pseudo_git.bb b/meta/recipes-devtools/pseudo/pseudo_git.bb
> > index c34580b4ff..c3f0a987fc 100644
> > --- a/meta/recipes-devtools/pseudo/pseudo_git.bb
> > +++ b/meta/recipes-devtools/pseudo/pseudo_git.bb
> > @@ -17,5 +17,7 @@ SRCREV = "c9670c27ff67ab899007ce749254b16091577e55"
> >  S = "${WORKDIR}/git"
> >  PV = "1.9.0+git${SRCPV}"
> >  
> > +TARGET_CPPFLAGS:remove = "-D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64"
> > +
> > 
> 
> We need to put some comments in here about what this is doing and why.
> 

Note that this was one of the issues I had with the
-D_FILE_OFFSET_BITS=64 -D_TIME_BITS=64 build. My guess is that we also
have to remove -D_TIME_BITS=64.


-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


  reply	other threads:[~2022-12-01 23:05 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-01 19:02 [PATCH 1/6] mdadm: Use _FILE_OFFSET_BITS to use largefile support Khem Raj
2022-12-01 19:02 ` [PATCH 2/6] acl: Enable largefile support by default Khem Raj
2022-12-06 15:27   ` [OE-core] " Richard Purdie
2022-12-01 19:02 ` [PATCH 3/6] btrfs-tools: Do not use 64bit functions for largefile support Khem Raj
2022-12-01 19:07   ` [OE-core] " Alexander Kanavin
     [not found]   ` <172CC0ECD8B86688.27320@lists.openembedded.org>
2022-12-06 14:58     ` Alexander Kanavin
2022-12-06 15:29       ` Richard Purdie
2022-12-06 16:09         ` Alexander Kanavin
2022-12-01 19:02 ` [PATCH 4/6] e2fsprogs: " Khem Raj
2022-12-01 19:02 ` [PATCH 5/6] libpciaccess: " Khem Raj
2022-12-01 19:02 ` [PATCH 6/6] pseudo: Disable LFS on 32bit arches Khem Raj
2022-12-01 19:12   ` [OE-core] " Richard Purdie
2022-12-01 23:05     ` Alexandre Belloni [this message]
2022-12-01 23:07       ` Khem Raj
2022-12-01 23:20         ` Richard Purdie
2022-12-01 23:22           ` Khem Raj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y4kzP3WMTabOHMYB@mail.local \
    --to=alexandre.belloni@bootlin.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=raj.khem@gmail.com \
    --cc=richard.purdie@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox