From: "Mikko Rapeli" <mikko.rapeli@bmw.de>
To: <steve@sakoman.com>
Cc: <anbelski@linux.microsoft.com>,
<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [dunfell][PATCH] glib-2.0: Rename patch file for CVE-2020-35457
Date: Wed, 3 Feb 2021 15:53:21 +0000 [thread overview]
Message-ID: <YBrG8IXZ18sRjupY@korppu> (raw)
In-Reply-To: <CAOSpxdYJNWu+cPtAH_ceHuOsYVYEo8ozh0RJRRcv54-B139fOA@mail.gmail.com>
On Wed, Feb 03, 2021 at 04:38:58AM -1000, Steve Sakoman wrote:
> On Wed, Feb 3, 2021 at 12:02 AM Mikko Rapeli <mikko.rapeli@bmw.de> wrote:
> >
> > Hi,
> >
> > On Wed, Feb 03, 2021 at 08:42:57AM +0000, Anatol Belski wrote:
> > > The naming convention needs to be help so the CVE is recognized as
> > > fixed by the tooling.
> >
> > Yocto CVE checker does detect CVE patches also from patch comments so
> > this change is not needed for that. This is sufficient:
> >
> > poky$ git grep CVE-2020-35457
> > meta/recipes-core/glib-2.0/glib-2.0/0001-goption-Add-a-precondition-to-avoid-GOptionEntry-lis.patch:CVE: CVE-2020-35457
>
> Yes, we are detecting the CVE patch from the patch comment.
>
> However our CVE patch guidelines do request that the patch be named
> with the CVE as the name:
>
> https://wiki.yoctoproject.org/wiki/Security
>
> (in the "Patch name convention and commit message" section)
>
> I'm sorry I didn't catch this when I merged this earlier. I always
> check the patch itself for the CVE tag, but I missed the name. So I'm
> happy to take this patch just to clean up the metadata and make it
> easy to see that this is a CVE patch.
Does anyone know why CVE ID in both name of the patch and in the CVE: tag are required?
Sometimes when copying patches over from upstream or other distros, I prefer to do as
little changes to them as possible. Adding CVE: tag and Upstream-Status are ok, but
for example renaming all patches files copied from a Debian/Ubuntu patch set is
a bit too much.
Cheers,
-Mikko
next prev parent reply other threads:[~2021-02-03 15:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 8:42 [dunfell][PATCH] glib-2.0: Rename patch file for CVE-2020-35457 Anatol Belski
2021-02-03 10:02 ` [OE-core] " Mikko Rapeli
2021-02-03 14:38 ` Steve Sakoman
2021-02-03 15:03 ` Anatol Belski
2021-02-03 15:53 ` Mikko Rapeli [this message]
2021-02-03 16:31 ` Steve Sakoman
2021-02-03 14:54 ` Anatol Belski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YBrG8IXZ18sRjupY@korppu \
--to=mikko.rapeli@bmw.de \
--cc=anbelski@linux.microsoft.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=steve@sakoman.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox