From: "Alexandre Belloni" <alexandre.belloni@bootlin.com>
To: Ross Burton <ross@burtonini.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] image_types: ext4 should always have large inodes
Date: Fri, 16 Jul 2021 16:26:10 +0200 [thread overview]
Message-ID: <YPGXApLL4WTfJHbp@piout.net> (raw)
In-Reply-To: <20210716122407.19416-1-ross.burton@arm.com>
Hi Ross,
This broke at least non-gpl3:
https://autobuilder.yoctoproject.org/typhoon/#/builders/75/builds/3691/steps/11/logs/stdio
On 16/07/2021 13:24:07+0100, Ross Burton wrote:
> mkfs.ext4 has logic where "small" file systems use "good old" 128-byte
> inodes instead of the default 256-byte inodes. This means that small
> filesystems are not 2038-safe as they only support 32-bit timestamps.
>
> However, "small" is defined as "less than 500MB", which is a fair number
> of filesystems in OpenEmbedded, especially when filesystems may be
> created small and expanded later.
>
> To avoid a discussion over how small a file system should be before
> it shouldn't be 2038-safe, simply build all filesystems with the default
> type so they all have 256-byte inodes and thus 64-bit timestamps.
>
> [ YOCTO #14478 ]
>
> Signed-off-by: Ross Burton <ross.burton@arm.com>
> ---
> meta/classes/image_types.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/image_types.bbclass b/meta/classes/image_types.bbclass
> index 954d6739ec..3dad86caa7 100644
> --- a/meta/classes/image_types.bbclass
> +++ b/meta/classes/image_types.bbclass
> @@ -90,7 +90,7 @@ oe_mkext234fs () {
>
> IMAGE_CMD_ext2 = "oe_mkext234fs ext2 ${EXTRA_IMAGECMD}"
> IMAGE_CMD_ext3 = "oe_mkext234fs ext3 ${EXTRA_IMAGECMD}"
> -IMAGE_CMD_ext4 = "oe_mkext234fs ext4 ${EXTRA_IMAGECMD}"
> +IMAGE_CMD_ext4 = "oe_mkext234fs ext4 -T default ${EXTRA_IMAGECMD}"
>
> MIN_BTRFS_SIZE ?= "16384"
> IMAGE_CMD_btrfs () {
> --
> 2.25.1
>
>
>
>
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2021-07-16 14:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-16 12:24 [PATCH] image_types: ext4 should always have large inodes Ross Burton
2021-07-16 14:26 ` Alexandre Belloni [this message]
2021-07-16 18:45 ` [OE-core] " Ross Burton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPGXApLL4WTfJHbp@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross@burtonini.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox