Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Ross Burton <ross@burtonini.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH 2/3] strace: handle loaded test systems
Date: Thu, 21 Oct 2021 15:48:00 +0200	[thread overview]
Message-ID: <YXFvkNkKhWFhFzTz@piout.net> (raw)
In-Reply-To: <20211019192614.153903-2-ross.burton@arm.com>

Hi Ross,

On 19/10/2021 20:26:13+0100, Ross Burton wrote:
> If the host is loaded when running the tests there is a good chance
> that strace-T.test will fail, as it does a sleep(1) and checks that
> the nanosleep() call lasted for 0.9-1.1 seconds.
> 
> Relax the test so that the test passes if the call takes less than two
> seconds.
> 
> [ YOCTO #14596 ]
> 
> Signed-off-by: Ross Burton <ross.burton@arm.com>
> ---
>  meta/recipes-devtools/strace/strace/ptest-sleep.patch | 7 +++++++
>  meta/recipes-devtools/strace/strace_5.14.bb           | 1 +
>  2 files changed, 8 insertions(+)
>  create mode 100644 meta/recipes-devtools/strace/strace/ptest-sleep.patch
> 
> diff --git a/meta/recipes-devtools/strace/strace/ptest-sleep.patch b/meta/recipes-devtools/strace/strace/ptest-sleep.patch
> new file mode 100644
> index 0000000000..5629dec319
> --- /dev/null
> +++ b/meta/recipes-devtools/strace/strace/ptest-sleep.patch
> @@ -0,0 +1,7 @@
> +diff --git a/tests/strace-T.expected b/tests/strace-T.expected
> +index 1ea020465..f78d3e2c8 100644
> +--- a/tests/strace-T.expected
> ++++ b/tests/strace-T.expected
> +@@ -1 +1 @@
> +-nanosleep\(\{tv_sec=1, tv_nsec=0\}, NULL\) = 0 <(1\.[01]|0\.9)[[:digit:]]{5}>
> ++nanosleep\(\{tv_sec=1, tv_nsec=0\}, NULL\) = 0 <(1\.|0\.9)[[:digit:]]{5}>

Those two builds have the patch and reliably failed:

https://autobuilder.yoctoproject.org/typhoon/#/builders/82/builds/2425/steps/12/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/82/builds/2428/steps/12/logs/stdio

> diff --git a/meta/recipes-devtools/strace/strace_5.14.bb b/meta/recipes-devtools/strace/strace_5.14.bb
> index a81bda04ba..9ae1367337 100644
> --- a/meta/recipes-devtools/strace/strace_5.14.bb
> +++ b/meta/recipes-devtools/strace/strace_5.14.bb
> @@ -13,6 +13,7 @@ SRC_URI = "https://strace.io/files/${PV}/strace-${PV}.tar.xz \
>             file://0001-caps-abbrev.awk-fix-gawk-s-path.patch \
>             file://ptest-spacesave.patch \
>             file://0001-strace-fix-reproducibilty-issues.patch \
> +           file://ptest-sleep.patch \
>             "
>  SRC_URI[sha256sum] = "901bee6db5e17debad4530dd9ffb4dc9a96c4a656edbe1c3141b7cb307b11e73"
>  
> -- 
> 2.25.1
> 

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#157202): https://lists.openembedded.org/g/openembedded-core/message/157202
> Mute This Topic: https://lists.openembedded.org/mt/86448553/3617179
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alexandre.belloni@bootlin.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 


-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


  reply	other threads:[~2021-10-21 13:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-19 19:26 [PATCH 1/3] strace: remove obsolete patch Ross Burton
2021-10-19 19:26 ` [PATCH 2/3] strace: handle loaded test systems Ross Burton
2021-10-21 13:48   ` Alexandre Belloni [this message]
2021-10-21 14:20     ` [OE-core] " Ross Burton
2021-10-21 15:10       ` Alexandre Belloni
2021-10-21 15:33         ` Ross Burton
2021-10-19 19:26 ` [PATCH 3/3] strace: remove TOOLCHAIN assignment Ross Burton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YXFvkNkKhWFhFzTz@piout.net \
    --to=alexandre.belloni@bootlin.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=ross@burtonini.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox