Openembedded Core Discussions
 help / color / mirror / Atom feed
From: <Mikko.Rapeli@bmw.de>
To: <richard.purdie@linuxfoundation.org>
Cc: <openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH] opkg: Fix poor operator combination choice
Date: Thu, 4 Nov 2021 14:35:32 +0000	[thread overview]
Message-ID: <YYPvsoYTwoCH3PRT@korppu> (raw)
In-Reply-To: <20211104140257.3622680-1-richard.purdie@linuxfoundation.org>

On Thu, Nov 04, 2021 at 02:02:57PM +0000, Richard Purdie wrote:
> Combining :append with += rarely makes sense. Improve it to use the standard
> format (and tweak the implied spacing).

Maybe I'm silly but I find :append with += safer to do than manually remembring
to add the space character.

-Mikko

> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
>  meta/recipes-devtools/opkg/opkg_0.4.5.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-devtools/opkg/opkg_0.4.5.bb b/meta/recipes-devtools/opkg/opkg_0.4.5.bb
> index 2760fc58786..8af047a51ff 100644
> --- a/meta/recipes-devtools/opkg/opkg_0.4.5.bb
> +++ b/meta/recipes-devtools/opkg/opkg_0.4.5.bb
> @@ -60,7 +60,7 @@ do_install_ptest () {
>  	sed -i -e '/@PYTHONPATH=. $(PYTHON) $^/a\\t@if [ "$$?" != "0" ];then echo "FAIL:"$^;else echo "PASS:"$^;fi' ${D}${PTEST_PATH}/tests/Makefile
>  }
>  
> -WARN_QA:append += "openssl-deprecation"
> +WARN_QA:append = " openssl-deprecation"
>  QAPKGTEST[openssl-deprecation] = "package_qa_check_openssl_deprecation"
>  def package_qa_check_openssl_deprecation (package, d, messages):
>      sane = True
> -- 
> 2.32.0
> 

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#157844): https://lists.openembedded.org/g/openembedded-core/message/157844
> Mute This Topic: https://lists.openembedded.org/mt/86816265/3616751
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [mikko.rapeli@bmw.de]
> -=-=-=-=-=-=-=-=-=-=-=-
> 


  reply	other threads:[~2021-11-04 14:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-04 14:02 [PATCH] opkg: Fix poor operator combination choice Richard Purdie
2021-11-04 14:35 ` Mikko.Rapeli [this message]
2021-11-04 22:05   ` Re: [OE-core] " Alex Stewart
2021-11-04 23:05     ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YYPvsoYTwoCH3PRT@korppu \
    --to=mikko.rapeli@bmw.de \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=richard.purdie@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox