Re: [OE-core] [PATCH 1/2] scripts/oe-setup-builddir: copy site.conf.sample out of template directories (if it exists)

[Alexandre Belloni <alexandre.belloni@bootlin.com>]

On 15/07/2022 18:00:57+0200, Alexander Kanavin wrote:
> On Fri, 15 Jul 2022 at 16:42, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > We'd always intended that site.conf was more something the user would
> > setup once for their environment and not need to change. It was
> > therefore deliberately left out of the auto-setup piece.
> > I hadn't remembered we have an sample version of it. I think a sample
> > is fine as an example of how a site might setup a shared downloads
> > directory or common proxy information but I don't think the layer
> > should be installing it, particularly if it can trample an existing
> > file which I think the patch could as it stands.
> 
> Ah I see where the problem is: the sample file is installed subject to
> existence of local.conf in the destination build directory, which is
> ok most of the time, but not all of the time. It should check for
> existence of site.conf.
> 
> The idea is to serve two use cases:
> - when setting up a build from the poky template, there's a sample
> file installed. Same as local.conf.sample, we give users something to
> play with via commented out examples. They'll never find it in
> meta-poky/conf, even you had no idea it's there :)
> - when setting up a build from an organizational template, the right
> servers get configured without any extra steps. Ross pointed out that
> can be achieved with 'meta-product/conf/site.conf', but that can't be
> edited when needed, and can't be used to configure different settings
> for different builds (e.g. where the caches are - such things can be
> under access control restrictions).
> 
> I think this is worth reworking and making the commit message clearer.
> Or we should come up with a different way to provide 'official' way to
> set up site.conf, because otherwise it's back to 'write a custom
> script'.
> 

I don't think you need a custom script for site.conf, it is searched for
relative to BBPATH? I usually just put it directly as conf/site.conf in
the custom layer so it is in version control and not copied to BUILDDIR.

> Alex

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#168121): https://lists.openembedded.org/g/openembedded-core/message/168121
> Mute This Topic: https://lists.openembedded.org/mt/92212803/3617179
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alexandre.belloni@bootlin.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 


-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com