Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: yang.xu@mediatek.com
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH v2] insane.bbclass: Skip patches not in oe-core by full path
Date: Wed, 17 Aug 2022 19:24:30 +0200	[thread overview]
Message-ID: <Yv0kTr/PBCFaj2k8@mail.local> (raw)
In-Reply-To: <20220815053935.15950-1-yang.xu@mediatek.com>

Hello,

This doesn't seem to work as expected:

https://autobuilder.yoctoproject.org/typhoon/#/builders/120/builds/1599/steps/12/logs/stdio

https://autobuilder.yoctoproject.org/typhoon/#/builders/100/builds/3296/steps/12/logs/stdio

https://autobuilder.yoctoproject.org/typhoon/#builders/128/builds/495/steps/13/logs/stdio

On 15/08/2022 05:39:35+0000, Yang Xu via lists.openembedded.org wrote:
> The full path of patch may contain '/meta/' but not in oe-core, skip
> patches by checking it starts with oe-core full path or not.
> 
> Signed-off-by: Yang Xu <yang.xu@mediatek.com>
> ---
>  meta/classes-global/insane.bbclass | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/classes-global/insane.bbclass b/meta/classes-global/insane.bbclass
> index 46ea41e271..42daf4388e 100644
> --- a/meta/classes-global/insane.bbclass
> +++ b/meta/classes-global/insane.bbclass
> @@ -1214,11 +1214,12 @@ python do_qa_patch() {
>      import re
>      from oe import patch
>  
> +    coremeta_path = os.path.join(d.getVar('COREBASE'), 'meta/')
>      for url in patch.src_patches(d):
>         (_, _, fullpath, _, _, _) = bb.fetch.decodeurl(url)
>  
>         # skip patches not in oe-core
> -       if '/meta/' not in fullpath:
> +       if not os.path.abspath(fullpath).startswith(os.path.abspath(coremeta_path)):
>             continue
>  
>         kinda_status_re = re.compile(r"^.*upstream.*status.*$", re.IGNORECASE | re.MULTILINE)
> -- 
> 2.25.1
> 

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#169350): https://lists.openembedded.org/g/openembedded-core/message/169350
> Mute This Topic: https://lists.openembedded.org/mt/93030817/3617179
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alexandre.belloni@bootlin.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 


-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


  reply	other threads:[~2022-08-17 17:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-15  5:39 [PATCH v2] insane.bbclass: Skip patches not in oe-core by full path Yang Xu
2022-08-17 17:24 ` Alexandre Belloni [this message]
2022-08-19  3:53   ` [OE-core] " Yang Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yv0kTr/PBCFaj2k8@mail.local \
    --to=alexandre.belloni@bootlin.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=yang.xu@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox