Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Mikko Rapeli <mikko.rapeli@linaro.org>
To: uvv.mail@gmail.com
Cc: Openembedded-core@lists.openembedded.org
Subject: Re: [PATCH v5 2/2] oeqa/selftest: Drop dependency on systemd-native
Date: Tue, 18 Feb 2025 14:09:13 +0200	[thread overview]
Message-ID: <Z7R4aTJKc8rICiV8@nuoska> (raw)
In-Reply-To: <20250218115647.40502-2-uvv.mail@gmail.com>

Hi,

On Tue, Feb 18, 2025 at 12:56:47PM +0100, uvv.mail@gmail.com wrote:
> From: Vyacheslav Yurkov <uvv.mail@gmail.com>
> 
> The tests don't need it. On top of that, this extra requirement
> creates a dependency loop between systemd-systemctl-native and util-linux.

Yes, this is the right thing to do.

Reviewed-by: Mikko Rapeli <mikko.rapeli@linaro.org>

Cheers,

-Mikko

> Signed-off-by: Vyacheslav Yurkov <uvv.mail@gmail.com>
> ---
>  meta/lib/oeqa/selftest/cases/uki.py | 1 -
>  meta/lib/oeqa/selftest/cases/wic.py | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/meta/lib/oeqa/selftest/cases/uki.py b/meta/lib/oeqa/selftest/cases/uki.py
> index cd20a99aca..9a1aa4e269 100644
> --- a/meta/lib/oeqa/selftest/cases/uki.py
> +++ b/meta/lib/oeqa/selftest/cases/uki.py
> @@ -94,7 +94,6 @@ WKS_FILE = "efi-uki-bootdisk.wks.in"
>  
>  # efi, uki and systemd features must be enabled
>  MACHINE_FEATURES:append = " efi"
> -DISTRO_FEATURES_NATIVE:append = " systemd"
>  IMAGE_CLASSES:append:pn-core-image-base = " uki"
>  
>  # uki embeds also an initrd, no systemd or udev
> diff --git a/meta/lib/oeqa/selftest/cases/wic.py b/meta/lib/oeqa/selftest/cases/wic.py
> index 207e487002..4f5d43b5ee 100644
> --- a/meta/lib/oeqa/selftest/cases/wic.py
> +++ b/meta/lib/oeqa/selftest/cases/wic.py
> @@ -1363,7 +1363,6 @@ WKS_FILE = "test_efi_plugin.wks"
>  
>  # efi, uki and systemd features must be enabled
>  MACHINE_FEATURES:append = " efi"
> -DISTRO_FEATURES_NATIVE:append = " systemd"
>  IMAGE_CLASSES:append:pn-core-image-base = " uki"
>  
>  # uki embeds also an initrd, no systemd or udev


  reply	other threads:[~2025-02-18 12:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-18 11:56 [PATCH v5 1/2] systemd: Build the systemctl executable uvv.mail
2025-02-18 11:56 ` [PATCH v5 2/2] oeqa/selftest: Drop dependency on systemd-native uvv.mail
2025-02-18 12:09   ` Mikko Rapeli [this message]
2025-02-19  9:44 ` [OE-core] [PATCH v5 1/2] systemd: Build the systemctl executable Richard Purdie
2025-02-19 10:02   ` Mikko Rapeli
2025-02-19 10:14     ` Vyacheslav Yurkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z7R4aTJKc8rICiV8@nuoska \
    --to=mikko.rapeli@linaro.org \
    --cc=Openembedded-core@lists.openembedded.org \
    --cc=uvv.mail@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox