Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Mikko Rapeli <mikko.rapeli@linaro.org>
To: Ross Burton <Ross.Burton@arm.com>
Cc: "openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH v2 2/9] testimage.bbclass: detect slirp from TEST_RUNQEMUPARAMS
Date: Tue, 12 Sep 2023 14:29:49 +0300	[thread overview]
Message-ID: <ZQBLrRsfpfu2e9JN@nuoska> (raw)
In-Reply-To: <3E62B71C-8B13-47B3-BE0C-A8A1716680A3@arm.com>

Hi,

On Tue, Sep 12, 2023 at 11:25:28AM +0000, Ross Burton wrote:
> On 23 Aug 2023, at 07:10, Mikko Rapeli via lists.openembedded.org <mikko.rapeli=linaro.org@lists.openembedded.org> wrote:
> > -    if d.getVar("QEMU_USE_SLIRP"):
> > +    if d.getVar("QEMU_USE_SLIRP") or bb.utils.contains('TEST_RUNQEMUPARAMS', 'slirp', True, False, d):
> >         slirp = True
> 
> This means we can remove the QEMU_USE_SLIRP variable too, right?

Yes. TEST_RUNQEMUPARAMS += "slirp" would be enough to run slirp with testimage.bbclass.

Cheers,

-Mikko


  reply	other threads:[~2023-09-12 11:29 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-23  6:10 [PATCH v2 1/9] core-image-minimal: increase extra space to pass df.py oeqa runtime test Mikko Rapeli
2023-08-23  6:10 ` [PATCH v2 2/9] testimage.bbclass: detect slirp from TEST_RUNQEMUPARAMS Mikko Rapeli
2023-08-23  6:25   ` [OE-core] " Khem Raj
2023-08-23  6:48     ` Mikko Rapeli
2023-08-23  7:31     ` Mikko Rapeli
2023-08-23  9:06       ` Richard Purdie
2023-08-23  9:47         ` Mikko Rapeli
2023-08-23  9:57           ` Alexander Kanavin
2023-08-23 10:49             ` Mikko Rapeli
     [not found]             ` <177DFD85A9F91D1D.28529@lists.openembedded.org>
2023-08-23 13:01               ` openssh ptest banner failure (was Re: [OE-core] [PATCH v2 2/9] testimage.bbclass: detect slirp from TEST_RUNQEMUPARAMS ) Mikko Rapeli
2023-08-23 13:24                 ` Alexander Kanavin
2023-08-23 13:28                   ` Mikko Rapeli
2023-08-23 13:26                 ` Richard Purdie
2023-08-23 10:49           ` [OE-core] [PATCH v2 2/9] testimage.bbclass: detect slirp from TEST_RUNQEMUPARAMS Richard Purdie
2023-08-23 11:47             ` Mikko Rapeli
2023-08-23 13:17               ` Richard Purdie
2023-09-12 11:25   ` Ross Burton
2023-09-12 11:29     ` Mikko Rapeli [this message]
2023-09-12 11:30       ` Ross Burton
2023-09-12 11:37         ` Mikko Rapeli
2023-08-23  6:10 ` [PATCH v2 3/9] selftest runtime_test.py: add testimage.bbclass slirp test Mikko Rapeli
2023-08-23 18:45   ` [OE-core] " Alexander Kanavin
2023-08-24  6:41     ` Mikko Rapeli
2023-08-24  6:58       ` Alexander Kanavin
2023-08-23  6:10 ` [PATCH v2 4/9] oeqa dnf_runtime.py: fix HTTP server IP address and port Mikko Rapeli
2023-08-23  6:10 ` [PATCH v2 5/9] oeqa selftest context.py: whitespace fix Mikko Rapeli
2023-08-23  6:10 ` [PATCH v2 6/9] oeqa selftest context.py: remove warning from missing meta-selftest Mikko Rapeli
2023-08-23  6:10 ` [PATCH v2 7/9] oeqa selftest context.py: fix git commands and set branch name Mikko Rapeli
2023-09-05 13:46   ` [OE-core] " Ross Burton
2023-08-23  6:10 ` [PATCH v2 8/9] oeqa selftest runtime_test.py: append to TEST_RUNQEMUPARAMS Mikko Rapeli
2023-08-23  6:10 ` [PATCH v2 9/9] oeqa selftest runtime_test.py: skip virgl_headless test if /dev/dri/renderD128 access fails Mikko Rapeli
2023-08-23 18:37   ` [OE-core] " Alexander Kanavin
2023-08-23 18:38     ` Alexander Kanavin
2023-08-23 18:39       ` Alexander Kanavin
     [not found]       ` <177E172FFEF11691.18238@lists.openembedded.org>
2023-08-23 18:42         ` Alexander Kanavin
2023-08-24  6:45     ` Mikko Rapeli
2023-08-24  6:56       ` Alexander Kanavin
     [not found]       ` <177E3F68E6CB83D4.13053@lists.openembedded.org>
2023-09-07  8:59         ` Alexander Kanavin
2023-09-07 10:54           ` Richard Purdie
2023-08-23 18:44 ` [OE-core] [PATCH v2 1/9] core-image-minimal: increase extra space to pass df.py oeqa runtime test Alexander Kanavin
2023-08-24  6:38   ` Mikko Rapeli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZQBLrRsfpfu2e9JN@nuoska \
    --to=mikko.rapeli@linaro.org \
    --cc=Ross.Burton@arm.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox