From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id F19E8CFC271 for ; Tue, 15 Oct 2024 06:44:58 +0000 (UTC) Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by mx.groups.io with SMTP id smtpd.web10.7266.1728974692730065175 for ; Mon, 14 Oct 2024 23:44:53 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=fJBtAvdc; spf=pass (domain: linaro.org, ip: 209.85.167.49, mailfrom: mikko.rapeli@linaro.org) Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-539e690479cso2656518e87.3 for ; Mon, 14 Oct 2024 23:44:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1728974691; x=1729579491; darn=lists.openembedded.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=uP1AgrNMqrFQ/YyH34wBhvV8SLWpfy1acMvL6xg5bWU=; b=fJBtAvdc7XBIr5wzSOq4yefIXg7QnsEuqCS9BOmG2F65IODzf8HoAiVHK+4aSOA3Rl fi0hkz/dsVDsEKtEAc8kMKmN2OLAfClC8w6z/OHZpYRNnDO11cufgnKK/1LfEdMzXC7W 7bHTKqdtI/aF0y6pX+Opj/pOVBZYDqeD3nmIqjXr6aaXnVrb5vjAzjhz3o7n+JwqsIWW t6T08IzHWk1e4znREP7F58neb/KqXU2TsdQw25Wqk2twdKuot6Dvf+LOn6E3o4rv+8dh IAVZ0h8biJez92q4Kxc4XLJAHrL90A7eTJGn8vcKRvXs63cl9Y6E/41bb1EXKQunCwyQ hzNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728974691; x=1729579491; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uP1AgrNMqrFQ/YyH34wBhvV8SLWpfy1acMvL6xg5bWU=; b=lebu3cGY9nhjsFf48mgULCR13KW0hRkLGs+eo4mBJH8UJFm9xzSqOtI++1qJPY21Ar ov6IzA41BoclLwBVyeZvyi6QKQuvrnjQ9DRt9mIAWbqzjWkjKqYAu3uKPFEyf2SFx1Ao k548IbAMhR1yyQVGeONyx0LO+NEqKrOQVsiQYPR5TFOy8v3aDUG7lKt5EySvvaAcgK0X lnCcduyLnFMnGtubz+UkaA3gbKsEcpsTAS51R54EcTokfcPjQ/Yr7uAcsfQGfroeCw8I NtlFLkMhZ0wQeei15HNSMTF5IjRGyFDXnpjdjnF2OPtz5cQNcz+Y7pqph0tZpK9Jv046 RgKA== X-Forwarded-Encrypted: i=1; AJvYcCXGwLd/W93Y2lfuGZEtP8Vk9z0u8arCSHDoPey9tCR1LlDvtU7eRBCEEjdCgQiafxazOtDlngXgupFo8s79M7WNsQ==@lists.openembedded.org X-Gm-Message-State: AOJu0Yx+divSKMDDwNZ09mg2zU5gt8e5NRXaBJ2QhHxzDRh9V1mspmGo YEBCXbAU+INq70Ees3e4N6S33CeaJM6QAoMfaRE3sVLrudFPilzq+G4qg+2mo1I= X-Google-Smtp-Source: AGHT+IElclmF1C6Lhw/fHA3GgJTG6xpFpozrX74a+UxCAA2vevtaZWXtaK9wyEfx73eyXNjKnUs5Pg== X-Received: by 2002:a05:6512:3196:b0:539:8fcd:510 with SMTP id 2adb3069b0e04-539e54ec228mr3843034e87.20.1728974690309; Mon, 14 Oct 2024 23:44:50 -0700 (PDT) Received: from nuoska (78-27-76-97.bb.dnainternet.fi. [78.27.76.97]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-53a00005fefsm81744e87.185.2024.10.14.23.44.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Oct 2024 23:44:48 -0700 (PDT) Date: Tue, 15 Oct 2024 09:44:45 +0300 From: Mikko Rapeli To: Richard Purdie , openembedded-core@lists.openembedded.org Subject: Re: [OE-core] [PATCH v8 0/8] systemd uki support Message-ID: References: <20241011122044.12222-1-mikko.rapeli@linaro.org> <17FE4B15CF045259.4702@lists.openembedded.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <17FE4B15CF045259.4702@lists.openembedded.org> List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Tue, 15 Oct 2024 06:44:58 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/205797 Hi, On Mon, Oct 14, 2024 at 01:30:56PM +0300, Mikko Rapeli via lists.openembedded.org wrote: > Hi, > > On Sun, Oct 13, 2024 at 08:43:15AM +0100, Richard Purdie wrote: > > On Fri, 2024-10-11 at 15:20 +0300, Mikko Rapeli via lists.openembedded.org wrote: > > > These changes enable building systemd uki images which combine > > > kernel, kernel command line, initrd and possibly signatures to > > > a single UEFI binary. This binary can be booted with UEFI firmware > > > and systemd-boot. No grub is needed and UEFI firmware and/or > > > systemd-boot provide possibilities for boot menus. > > > The uki binary can also be signed for UEFI secure boot > > > so the secure boot extends from firmware to kernel and initrd. > > > Binding secure boot to full userspace is then easier since for example > > > kernel command line and initrd contain the support needed to mount > > > encrypted dm-verity etc partitions, and/or create partitions on demand > > > with systemd-repart using device specific TPM devices for encryption. > > > > > > Tested on qemuarm64-secureboot machine from meta-arm with changes to > > > support secure boot. Slightly different configuration tested on > > > multiple arm64 System Ready boards with UEFI firmware, real and firmware > > > based TPM devices. Tested with ovmf firmware on x86_64 with selftests but > > > without secure boot which seems to be harder to setup in ovmf. > > > > > > Sadly I see two wic selftests, wic.Wic2.test_rawcopy_plugin_qemu and > > > wic.Wic2.test_expand_mbr_image, failing when executing all wic selftests > > > on a build machine with zfs filesystem. Will investigate this further. > > > The issue seems to be in mkfs.ext4 producing broken filesystem, and partially > > > in the tests which don't run the correct rootfs file (.ext4 vs .wic). > > > Will debug this further and it is IMO unrelated to these changes since > > > they reproduce on pure master branch without this series. > > > > > > v8: fixed comments from Ross Burton: debug print from warning to debug, > > > ��� dropped duplicate DISTRO_FEATURE setting for systemd in tests, > > > ��� removed aarch64 comment from tests which are currently x86 only. > > > ��� Fixed the new aarch64 wic selftest to run on both genericarm64 > > > ��� and qemuarm64 by adding bios, virtio disk driver etc settings > > > ��� for runqemu (already set in genericarm64 but missing from qemuarm64). > > > > > > v7: add missing "ovmf" to runqemu argument to > > > ��� test_efi_plugin_plain_systemd_boot_qemu_x86 to fix boot hang > > > > > > v6: fixes wic refactoring botch which broken non-uki systemd-boot usage on > > > ��� genericarm64 reported by Ross Burton , added > > > ��� selftest to cover this wks usage on x86 and aarch64 > > > > > > v5: drop patch "image_types_wic.bbclass: set systemd-boot and os-release > > > ��� dependency for all archs" since systemd-boot does not support all > > > ��� architectures > > > > > > v4: handle missing runqemu variable from build config, add > > > python3-pefile to fast ptest list > > > > > > v3: rebased, fixed and added more sefltests, removed wic plugin side uki > > > support > > > > > > v2: https://lists.openembedded.org/g/openembedded-core/message/204090 > > > > > > Michelle Lin (1): > > > � uki.bbclass: add class for building Unified Kernel Images (UKI) > > > > > > Mikko Rapeli (7): > > > � wic bootimg-efi.py: keep timestamps and add debug prints > > > � wic bootimg-efi.py: change UKI support from wic plugin to uki.bbclass > > > � oeqa selftest uki.py: add tests for uki.bbclass > > > � oeqa selftest efibootpartition.py: add TEST_RUNQEMUPARAMS to runqemu > > > � oeqa selftest efibootpartition.py: remove systemd-boot from grub-efi > > > ��� test > > > � oeqa selftest wic.py: add TEST_RUNQEMUPARAMS to runqemu > > > � oeqa selftest wic.py: support UKIs via uki.bbclass > > > > > > > I'm still seeing failures in CI: > > > > https://valkyrie.yoctoproject.org//#/builders/23/builds/249/steps/14/logs/stdio > > > > which is despite setting: > > > > https://git.yoctoproject.org/poky/commit/?h=master-next&id=6211ad9210e82a5a8dd157c63752ad332c2f5de6 > > > > QEMU_USE_KVM = "False" > > > > into the test to ensure it doesn't have the issue the barebox testing > > was seeing. > > > > I've sent a patch to try and clean up the lock error. > > > > There is also this: > > > > https://valkyrie.yoctoproject.org//#/builders/76/builds/235 > > https://valkyrie.yoctoproject.org//#/builders/48/builds/181 > > https://valkyrie.yoctoproject.org//#/builders/54/builds/230 > > > > which is due to the binaries being run "in tree" within the edk2 build > > as well as from the sysroot. This generates two sets of pyc files which > > then conflict (or not) depending on which host the build ran on and > > which pyc files are in sstate. > > > > We're going to have to get this fixed before it can merge, probably by > > deleting the pyc files at install unless we can find anything more > > elegant. > > Sent an ovmf-native patch separately for this. With ovmf-native change applied to master, can this series be tried again? Or are some changes needed? Cheers, -Mikko