Re: [OE-core] [PATCH v8 0/8] systemd uki support

[Mikko Rapeli <mikko.rapeli@linaro.org>]

Hi,

On Tue, Oct 15, 2024 at 03:13:44PM +0100, Richard Purdie wrote:
> On Tue, 2024-10-15 at 14:23 +0300, Mikko Rapeli wrote:
> > Hi,
> > 
> > On Tue, Oct 15, 2024 at 11:43:33AM +0100, Richard Purdie wrote:
> > > The arm test still fails:
> > > 
> > > https://valkyrie.yoctoproject.org/#/builders/23/builds/267/steps/14/logs/stdio
> > > 
> > > The traceback is at least cleaner now I fixed the lock error. I did
> > > test with KVM disabled.
> > 
> > Bugger. I had tested this on qemuarm64 and genericarm64 on an x86_64
> > build host with Ubuntu 22.04. Is this an arm64 build host with Ubuntu
> > 20.04?
> > 
> > I will remove the tests as it is clearly too hard to get these
> > running.
> > 
> > It is a bit hard to figure out in which environments selftests are
> > running.
> 
> Please don't remove them. The automated tests are the main reason the
> project actually continues to function in any sane way.
> 
> For that reason I really do appreciate having them and would like to
> see more of them.
> 
> Unfortunately I don't know enough about the subject area to help on
> this. I have at least tried to improve the failure messages and run out
> the one area I knew was potentially an issue (KVM on arm).

Did the test pass on x86_64 build host in your CI?

How about I run the wic.Wic2.test_efi_plugin_plain_systemd_boot_qemu_aarch64
test only on x86_64 BUILD_ARCH and aarch64 TARGET_ARCH for now?

A decorator like this could help:

--- a/meta/lib/oeqa/core/decorator/data.py
+++ b/meta/lib/oeqa/core/decorator/data.py
@@ -228,3 +228,15 @@ class skipIfNotArch(OETestDecorator):
         arch = self.case.td['HOST_ARCH']
         if arch not in self.archs:
              self.case.skipTest('Test skipped on %s' % arch)
+
+@registerDecorator
+class skipIfNotBuildArch(OETestDecorator):
+    """
+    Skip test if BUILD_ARCH is not present in the tuple specified.
+    """
+
+    attrs = ('archs',)
+    def setUpDecorator(self):
+        arch = self.case.td['BUILD_ARCH']
+        if arch not in self.archs:
+             self.case.skipTest('Test skipped on %s' % arch)

Cheers,

-Mikko