Re: [OE-core] [PATCH v7 4/8] oeqa selftest uki.py: add tests for uki.bbclass

[Mikko Rapeli <mikko.rapeli@linaro.org>]

Hi,

On Thu, Oct 10, 2024 at 08:17:38PM +0000, Ross Burton wrote:
> On 10 Oct 2024, at 09:56, Mikko Rapeli via lists.openembedded.org <mikko.rapeli=linaro.org@lists.openembedded.org> wrote:
> > +# efi, uki and systemd features must be enabled
> > +INIT_MANAGER = "systemd"
> 
> Yes
> 
> > +MACHINE_FEATURES:append = " efi"
> 
> Maybe we should add this to the qemu machines, as they can do EFI.
> 
> > +DISTRO_FEATURES:append = " uki"
> 
> Fine

Leftover, should not be needed so removing.

> > +DISTRO_FEATURES:append = " systemd"
> > +DISTRO_FEATURES_NATIVE:append = " systemd”
> 
> These are not needed as INIT_MANAGER causes more than a variable assignment, it manipulates DISTRO_FEATURES.

Ok trying without.

> > +            # Verify from efivars that firmware was:
> > +            # x86_64, qemux86_64 = edk2
> > +            # arm,  = u-boot
> > +            cmd = "echo $( cat /sys/firmware/efi/efivars/LoaderFirmwareInfo-4a67b082-0a4c-41cf-b6c7-440b29bb8c4f ) | grep 'EDK II'"
> > +            status, output = qemu.run_serial(cmd)
> > +            self.assertEqual(1, status, 'Failed to run command "%s": %s' % (cmd, output))
> 
> Looks like the comments are ahead of the test here - this is assuming the MACHINE is qemux86-64.

Yes, all tests are for now x86 only. I could add aarch64 but
genericarm64 and qemuarm64 are quite different so would need
to figure out the efi boot issues in both. I was not sure
which archs and machines run these tests. Tests should not
set MACHINE related details, or?

Cheers,

-Mikko