Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com>
To: Martin Jansa <martin.jansa@gmail.com>
Cc: openembedded-core@lists.openembedded.org, steve@sakoman.com
Subject: Re: [OE-core] [PATCH v3] xmlto: backport a patch to fix build with gcc-14 on host
Date: Tue, 5 Nov 2024 10:52:30 +0100	[thread overview]
Message-ID: <Zynq3g7_0jJQGt5f@bootlin-mathieu> (raw)
In-Reply-To: <20241104145922.1039681-1-martin.jansa@gmail.com>

On Mon, Nov 04, 2024 at 03:59:21PM +0100, Martin Jansa wrote:
> * need to add dependency on flex-native because now when the
>   .l file is modified by the .patch file it will try to regenerate
>   the c code and fail:
> 
> | make[1]: Entering directory 'work/x86_64-linux/xmlto-native/0.0.28-r0/build'
> | /bin/bash ../xmlto-0.0.28/ylwrap ../xmlto-0.0.28/xmlif/xmlif.l .c xmlif/xmlif.c -- /bin/bash 'work/x86_64-linux/xmlto-native/0.0.28-r0/xmlto-0.0.28/missing' flex
> | work/x86_64-linux/xmlto-native/0.0.28-r0/xmlto-0.0.28/missing: line 81: flex: command not found
> | WARNING: 'flex' is missing on your system.
> |          You should only need it if you modified a '.l' file.
> |          You may want to install the Fast Lexical Analyzer package:
> |          <https://github.com/westes/flex>
> 
> * backport
>   https://pagure.io/xmlto/c/32376c053733c6c0ebaca3c25c0725509342fdf3?branch=master
>   as well, so that patched xmlif/xmlif.c is newer than xmlif/xmlif.l and the build
>   won't try to regenerate it with flex as that leads to random build failures reported
>   in:
>   https://lists.openembedded.org/g/openembedded-core/message/206412
>   https://errors.yoctoproject.org/Errors/Details/810853/
>   https://lists.openembedded.org/g/openembedded-core/message/206496
>   https://valkyrie.yoctoproject.org/#/builders/29/builds/355
> 
> Signed-off-by: Martin Jansa <martin.jansa@gmail.com>
> ---
> v3: add touch ${S}/xmlif/xmlif.c
>     to make sure xmlif.c is newer than xmlif.l after do_patch (order of
>     .patch files in SRC_URI isn't enough) to prevent regenerating it
>     with flex-native which isn't in DEPENDS
> 

Hi Martin,

This is still for Kirkstone branch, right ?

-- 
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


  reply	other threads:[~2024-11-05  9:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-04 14:59 [PATCH v3] xmlto: backport a patch to fix build with gcc-14 on host Martin Jansa
2024-11-05  9:52 ` Mathieu Dubois-Briand [this message]
2024-11-05 11:38   ` [OE-core] " Martin Jansa
2024-11-05 13:53     ` Steve Sakoman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zynq3g7_0jJQGt5f@bootlin-mathieu \
    --to=mathieu.dubois-briand@bootlin.com \
    --cc=martin.jansa@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=steve@sakoman.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox