Re: bitbake.conf: require lz4 instead of lz4c

[Justin Bronder <jsbronder@cold-front.org>]

On 06/11/24 07:50 +0000, Richard Purdie wrote:
> On Tue, 2024-11-05 at 10:37 -0500, Justin Bronder via lists.openembedded.org wrote:
> > With bitbake commit 'bb: compress: use lz4 instead of lz4c' we require
> > lz4, not lz4c [1].� Going as far back as Ubuntu 16.04/Fedora 25, they
> > are packaged together so it should be safe to simply adjust the
> > requirement from lz4c to lz4.
> > 
> > Note that the two are largely the same, but upstream has considered lz4c
> > deprecated since at least 2018 [2].
> > 
> > 1. https://git.openembedded.org/bitbake/commit/?id=907472034b344e4eb73cfd43059a413469f52e1c
> > 2. https://github.com/lz4/lz4/pull/553
> > 
> > Signed-off-by: Justin Bronder <jsbronder@cold-front.org>
> > ---
> > �meta/conf/bitbake.conf | 2 +-
> > �1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> > index eda505c861..14e761e2e7 100644
> > --- a/meta/conf/bitbake.conf
> > +++ b/meta/conf/bitbake.conf
> > @@ -517,7 +517,7 @@ HOSTTOOLS += " \
> > ���� [ ar as awk basename bash bunzip2 bzip2 cat chgrp chmod chown chrpath cmp comm cp cpio \
> > ���� cpp cut date dd diff diffstat dirname du echo egrep env expand expr false \
> > ���� fgrep file find flock g++ gawk gcc getconf getopt git grep gunzip gzip \
> > -��� head hostname iconv id install ld ldd ln ls lz4c make md5sum mkdir mkfifo mknod \
> > +��� head hostname iconv id install ld ldd ln ls lz4 make md5sum mkdir mkfifo mknod \
> > ���� mktemp mv nm objcopy objdump od patch perl pr printf pwd \
> > ���� python3 pzstd ranlib readelf readlink realpath rm rmdir rpcgen sed seq sh \
> > ���� sha1sum sha224sum sha256sum sha384sum sha512sum \
> > 
> 
> This caused a failure in barebox:
> 
> https://valkyrie.yoctoproject.org/#/builders/23/builds/409/steps/14/logs/stdio
> 

I see, sorry about that.

What would be the recommended path forward?

- Add lz4c to HOSTTOOLS_NONFATAL so it's still symlinked.  This would fix barebox and any other recipes that still depend on lz4c on distributions where lz4c is still packaged but leave others without an early warning system.
- Submit patches to barebox and others to use lz4 instead of lz4c.  This is probably more correct but will leave Tumbleweed unsupported by default with other distros to presumably follow.
- Convince Tumbleweed (and others) to continue packaging lz4c.


-- 
Justin Bronder