Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Alexander Kanavin <alexander.kanavin@linux.intel.com>
To: Paul Eggleton <paul.eggleton@intel.com>
Cc: Leonardo Sandoval <leonardo.sandoval.gonzalez@intel.com>,
	Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: automatic recipe upgrades - making them better and sweeter
Date: Tue, 7 Nov 2017 17:20:18 +0200	[thread overview]
Message-ID: <a01ffbee-b133-0481-9836-11239fad8294@linux.intel.com> (raw)
In-Reply-To: <14953303.KfuyF98Oh2@peggleto-mobl.ger.corp.intel.com>

On 11/06/2017 10:04 PM, Paul Eggleton wrote:
>> 3) 'devtool finish' currently does not handle the recipe upgrade
>> situation well: the new recipe and patches are placed side by side with
>> the current recipe. The old stuff should be removed, and a tentative
>> commit should be created. So maybe add a 'devtool finish-upgrade'.
> 
> That's not what's supposed to happen - it should already be deleting the
> original files (it takes a record of the copied files when you run devtool
> upgrade, and then when you run devtool finish it deletes those and moves the
> new ones across from the workspace). If that's not working it's a bug and I
> would appreciate a reproducer. I'd certainly prefer that we keep to one finish
> command that does its best to "do the right thing" depending on the situation.

For me it happens every time. I run 'devtool finish <recipe> ../meta' 
and while the new files are placed into the correct dir in the layer, 
the old ones all remain (which is especially annoying if I then need to 
manually sort the added/deleted patch files).

Can you run a quick check to see if it happens on your side? Something 
trivial, like ffmpeg would do. I can then file a bug.

Also, there shouldn't be a need to specify the destination at all, if 
the recipe is modified or upgraded.


Alex



  reply	other threads:[~2017-11-07 15:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-06 11:50 automatic recipe upgrades - making them better and sweeter Alexander Kanavin
2017-11-06 20:04 ` Paul Eggleton
2017-11-07 15:20   ` Alexander Kanavin [this message]
2017-11-07 20:17     ` Paul Eggleton
2017-11-08 13:09       ` Alexander Kanavin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a01ffbee-b133-0481-9836-11239fad8294@linux.intel.com \
    --to=alexander.kanavin@linux.intel.com \
    --cc=leonardo.sandoval.gonzalez@intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=paul.eggleton@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox