RE: [OE-core] [PATCH] rootfs-postcommands.bbclass: Change the default.target location

[Peter Kjellerstedt <peter.kjellerstedt@axis.com>]

> -----Original Message-----
> From: Richard Purdie <richard.purdie@linuxfoundation.org>
> Sent: den 10 januari 2022 16:44
> To: Peter Kjellerstedt <peter.kjellerstedt@axis.com>; openembedded-
> core@lists.openembedded.org
> Subject: Re: [OE-core] [PATCH] rootfs-postcommands.bbclass: Change the
> default.target location
> 
> On Mon, 2022-01-10 at 16:37 +0100, Peter Kjellerstedt wrote:
> > Rather than adding a default.target in /etc/systemd/system, modify the
> > one in /usr/lib/systemd/system.
> 
> Why?
> 
> (the commit message needs to say why as well as what it does)

I thought it did (avoid having two links where one will suffice).

> 
> Cheers,
> 
> Richard

Thinking a bit more about this though, I am not sure I can win. We have 
had a corresponding local patch for many years, and it seems natural to 
have the link only in /usr/lib/systemd/system. However, for a system that 
uses package management (which we do not), it may not be as natural, 
since then updating the systemd package in runtime would restore systemd's 
default.target rather than the one that was installed with the system.

Would you accept a patch that instead introduces a variable for the path 
to the default.target link, with the following definition:

SYSTEMD_DEFAULT_TARGET_PATH ?= "${@bb.utils.contains('IMAGE_FEATURES', 'package-management', '${sysconfdir}/systemd/system', '${systemd_system_unitdir}', d}"

That would make it reasonably sane by default, but still allow it to be 
overridden if you have other ideas for your system.

//Peter