From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Enguerrand de Ribaucourt
<enguerrand.de-ribaucourt@savoirfairelinux.com>,
openembedded-core@lists.openembedded.org
Cc: adrian.freihofer@gmail.com, Ross.Burton@arm.com,
mohammed.raza@savoirfairelinux.com
Subject: Re: [OE-core] [PATCH 0/6] devtool: ide: Improve VSCode support
Date: Thu, 15 Feb 2024 17:11:17 +0000 [thread overview]
Message-ID: <a23568b22a49469e65a2ad94dd6a4db3d54fb265.camel@linuxfoundation.org> (raw)
In-Reply-To: <20240215170422.659073-1-enguerrand.de-ribaucourt@savoirfairelinux.com>
On Thu, 2024-02-15 at 18:04 +0100, Enguerrand de Ribaucourt wrote:
> These patches improve the VSCode support in devtool ide-sdk from
> Adrian Freihofer.
>
> I added a generic C++ configuration for the VScode
> extension while awaiting for autotools support.
>
> A refactoring is proposed for the meson class. Without absolute compiler
> paths, the linter inside VSCode will not be able to find the
> cross-compiler. Let me know if you have any concerns about this
> refactoring.
>
> The other bug fixes are relatively minor and make the tool work for some edge
> cases.
I noticed none of the patches in this series have Signed-off-by lines
which needs to be fixed before we can merge them. Patchtest should be
along shortly to say that too!
I need to think about and test the meson one a bit more as absolute
paths can be a source of problems. I've not looked into the others in
detail yet.
Cheers,
Richard
next prev parent reply other threads:[~2024-02-15 17:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-15 17:04 [PATCH 0/6] devtool: ide: Improve VSCode support Enguerrand de Ribaucourt
2024-02-15 17:04 ` [PATCH 1/6] devtool: ide: Fix topdir exception for fallback mode Enguerrand de Ribaucourt
2024-02-15 23:02 ` adrian.freihofer
2024-02-15 17:04 ` [PATCH 2/6] devtool: ide_sdk: Use bitbake's python3 for generated scripts Enguerrand de Ribaucourt
2024-02-15 17:04 ` [PATCH 3/6] devtool: code: Add source mapping for debug source files Enguerrand de Ribaucourt
2024-02-15 23:21 ` adrian.freihofer
2024-02-15 17:04 ` [PATCH 4/6] devtool: ide: vscode: Configure read-only files Enguerrand de Ribaucourt
2024-02-15 17:04 ` [PATCH 5/6] meson: use absolute cross-compiler paths Enguerrand de Ribaucourt
2024-02-15 17:04 ` [PATCH 6/6] devtool: code: Provide a generic C++ configuration Enguerrand de Ribaucourt
2024-02-15 23:15 ` adrian.freihofer
2024-02-15 17:11 ` Richard Purdie [this message]
2024-02-15 22:38 ` [OE-core] [PATCH 0/6] devtool: ide: Improve VSCode support Peter Kjellerstedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a23568b22a49469e65a2ad94dd6a4db3d54fb265.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=Ross.Burton@arm.com \
--cc=adrian.freihofer@gmail.com \
--cc=enguerrand.de-ribaucourt@savoirfairelinux.com \
--cc=mohammed.raza@savoirfairelinux.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox