From: Paul Barker <paul@pbarker.dev>
To: oobitots@cisco.com, openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH V2] patch.py: add checks for patch_path
Date: Wed, 14 Jan 2026 13:39:10 +0000 [thread overview]
Message-ID: <a257bb5d7582180349df7c5bf468441b70f91d17.camel@pbarker.dev> (raw)
In-Reply-To: <20260114125207.497436-1-oobitots@cisco.com>
[-- Attachment #1: Type: text/plain, Size: 1165 bytes --]
On Wed, 2026-01-14 at 04:52 -0800, Oleksiy Obitotskyy via
lists.openembedded.org wrote:
> All URLs from SRC checked to be a patch.
> In some rare cases, when we have "diff" or
> "patch" into URL it is treated as a patch not
> like proper resource (e.g. repository). This
> happens in case of using mirrors. Without
> pre-downloaded repository archive we have
> directory into downloads and exit from
> patch_path before checking for patch/diff.
>
> Let's limit patch_path call for url's that
> has "apply" parameter set or has original
> extensions .diff or .patch.
>
> Error example for this URL:
> git://github.com/pkg/diff;name=diff;\
> destsuffix=build/vendor/src/github.com/pkg/diff;branch=main;protocol=https
>
> ERROR: nativesdk-yq-4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0 do_patch: \
> Importing patch 'github.com.pkg.diff' with striplevel '1'
> FileNotFoundError(2, 'No such file or directory')
>
> Signed-off-by: Oleksiy Obitotskyy <oobitots@cisco.com>
You mention the `apply` parameter in your commit message. Can you just
add `;apply=no` to the relevant SRC_URI entry?
Best regards,
--
Paul Barker
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 252 bytes --]
prev parent reply other threads:[~2026-01-14 13:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-14 12:52 [PATCH V2] patch.py: add checks for patch_path Oleksiy Obitotskyy
2026-01-14 13:39 ` Paul Barker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a257bb5d7582180349df7c5bf468441b70f91d17.camel@pbarker.dev \
--to=paul@pbarker.dev \
--cc=oobitots@cisco.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox