From: Mark Hatle <mark.hatle@windriver.com>
To: Alexander Kanavin <alex.kanavin@gmail.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 04/12] qemu: build target variant with gtk+, and nativesdk variant without sdl
Date: Tue, 12 Feb 2019 11:20:43 +0100 [thread overview]
Message-ID: <a28722ec-cf05-d7b7-0502-f471f747aebf@windriver.com> (raw)
In-Reply-To: <CANNYZj8-44W5RyA+VF_7QPWxdouh=GbHtKwutWKeVwpjTgP_ng@mail.gmail.com>
On 2/8/19 9:58 AM, Alexander Kanavin wrote:
> On Fri, 8 Feb 2019 at 16:56, Mark Hatle <mark.hatle@windriver.com> wrote:
>>> Patch 3 changes things in meta-poky/, and patch 4 changes things in
>>> meta/, so they cannot be combined unfortunately. I can however swap
>>> their order, so that there is less confusion.
>>
>> Swap the order and add a copy of the commit message (from 4 to 3) then. That
>> should lesson anyone's questions if they need to figure out why it changed in
>> the future.
>
> Currently the commits are:
>
> commit 341ab87cf326dc1f1d7a3b83d624cde04047f43e
> Author: Alexander Kanavin <alex.kanavin@gmail.com>
> Date: Thu Dec 27 15:17:26 2018 +0100
>
> local.conf.sample: adjust the qemu config to enable gtk+ instead of sdl
Reading the above, I didn't know why you changed the qemu config to enable gtk+.
The commit below has the magic line:
'As sdl is deprecated in favor of gtk+, it should not be the default.'
Once you add that, it's clear to me why the change was made if I ever look at
the local.conf.sample (using git log or git blame).
(Sorry my reply had been delayed, I missed this earlier.)
--Mark
> Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
>
> commit 1170d353029dfb3f1a5ed9bab567e353bd034dfa
> Author: Alexander Kanavin <alex.kanavin@gmail.com>
> Date: Thu Dec 27 15:33:27 2018 +0100
>
> qemu: build target variant with gtk+, and nativesdk variant without sdl
>
> As sdl is deprecated in favor of gtk+, it should not be the default.
>
> Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
>
> I'm confused, what should go where?
>
> Alex
>
next prev parent reply other threads:[~2019-02-12 10:20 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 14:45 [PATCH 00/12] Enable accelerated OpenGL in qemu Alexander Kanavin
2019-02-08 14:45 ` [PATCH 01/12] virglrenderer: add a recipe Alexander Kanavin
2019-02-09 9:44 ` Martin Jansa
2019-02-09 10:06 ` Alexander Kanavin
2019-02-09 13:19 ` Martin Jansa
2019-02-09 16:43 ` Alexander Kanavin
2019-02-09 17:09 ` Martin Jansa
2019-02-09 17:16 ` Alexander Kanavin
2019-02-09 17:23 ` Khem Raj
2019-02-11 15:24 ` Khem Raj
2019-02-12 11:33 ` Alexander Kanavin
2019-02-08 14:45 ` [PATCH 02/12] qemu: enable virglrenderer and glx options for native/nativesdk builds Alexander Kanavin
2019-02-08 23:12 ` Martin Jansa
2019-02-08 23:32 ` Alexander Kanavin
2019-02-09 9:32 ` Martin Jansa
2019-02-09 10:04 ` Alexander Kanavin
2019-02-08 14:45 ` [PATCH 03/12] local.conf.sample: adjust the qemu config to enable gtk+ instead of sdl Alexander Kanavin
2019-02-08 14:45 ` [PATCH 04/12] qemu: build target variant with gtk+, and nativesdk variant without sdl Alexander Kanavin
2019-02-08 15:31 ` Mark Hatle
2019-02-08 15:43 ` Alexander Kanavin
2019-02-08 15:55 ` Mark Hatle
2019-02-08 15:58 ` Alexander Kanavin
2019-02-12 10:20 ` Mark Hatle [this message]
2019-02-12 10:58 ` Alexander Kanavin
2019-02-08 14:45 ` [PATCH 05/12] qemu: remove support for building against host sdl Alexander Kanavin
2019-02-08 14:45 ` [PATCH 06/12] qemu: add a gettext-native dependency to gtk option Alexander Kanavin
2019-02-08 14:45 ` [PATCH 07/12] qemu: add a patch to avoid a missing definition error Alexander Kanavin
2019-02-08 14:45 ` [PATCH 08/12] qemu: add environment variable wrappers to make qemu look good with gtk frontend Alexander Kanavin
2019-02-08 14:45 ` [PATCH 09/12] qemu: add a backported patch to fix egl-headless support Alexander Kanavin
2019-02-08 14:45 ` [PATCH 10/12] runqemu: add options for enabling virgl GL acceleration Alexander Kanavin
2019-02-08 14:45 ` [PATCH 11/12] runqemu: do not check for GL libraries Alexander Kanavin
2019-02-08 14:45 ` [PATCH 12/12] selftest: add tests for virgl GL acceleration Alexander Kanavin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a28722ec-cf05-d7b7-0502-f471f747aebf@windriver.com \
--to=mark.hatle@windriver.com \
--cc=alex.kanavin@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox