Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Haris Okanovic <haris.okanovic@ni.com>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] run-postinsts: Print message before running deferred postinst scripts
Date: Tue, 6 Dec 2016 13:01:45 -0600	[thread overview]
Message-ID: <a451efe2-f5fe-ca22-28ef-06571ab8ac09@ni.com> (raw)
In-Reply-To: <CAJTo0La+W7qJikWqjHh6f90M_Cr_v2EUwegE+CGRLYCR5D6K8A@mail.gmail.com>



On 12/05/2016 04:51 PM, Burton, Ross wrote:
>
> On 5 December 2016 at 21:48, Haris Okanovic <haris.okanovic@ni.com
> <mailto:haris.okanovic@ni.com>> wrote:
>
>     Opkg can defer running postinst scripts to first boot, which can take
>     a while on some systems. The output of `opkg configure` (or whatever pm
>     is used) is redirected to a file when logging is enabled
>     (I.e. $POSTINST_LOGGING == 1), making the machine appear hung during
>     this process. This change simply prints a wait message on the console
>     to inform the user of this potentially long and silent operation so
>     that they do not mistakenly reboot their machine.
>
>
> This isn't opkg specific, all backends can do it.

I wrote a more generic commit message in V2.

>
>
>     Why not simply `tee` the output instead?
>     Tee might be provided by BusyBox in some distros, which may need to run
>     update-alternatives in the very postinst scripts being executed by this
>     process. It's therefore not safe to assume Tee (or any other packaged
>     util) is available until the configure process finishes.
>
>
> Are the alternatives not configured at rootfs time, so it should be fine
> to run tee?  (as if tee isn't safe, then neither is sed).

`tee` wasn't configured in Fido builds of NI Linux RT -- I.e. 
Busybox.postinst got deferred. I'm not sure if that's the OE default or 
the result of some distro-specific tweaks we made, but I decided not to 
rely on it for that reason. It's possible tee might work on some 
configurations.

I'm not sure why sed is significant. The only non-builtins in 
run-postinsts are update-rc.d, rm, and $pm.

>
> Ross


  reply	other threads:[~2016-12-06 21:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-05 21:48 [PATCH] run-postinsts: Print message before running deferred postinst scripts Haris Okanovic
2016-12-05 22:51 ` Burton, Ross
2016-12-06 19:01   ` Haris Okanovic [this message]
2016-12-06 19:51   ` [PATCH v2] " Haris Okanovic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a451efe2-f5fe-ca22-28ef-06571ab8ac09@ni.com \
    --to=haris.okanovic@ni.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=ross.burton@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox