From: "Joshua Watt" <JPEWhacker@gmail.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>,
Alexander Kanavin <alex.kanavin@gmail.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH 13/22] bash: update 5.0 -> 5.1
Date: Thu, 7 Jan 2021 12:43:07 -0600 [thread overview]
Message-ID: <a75c31fd-9617-1bc0-e895-ac40802245ce@gmail.com> (raw)
In-Reply-To: <1b8809a765eb36211ecc39a9e096ac207178884d.camel@linuxfoundation.org>
[-- Attachment #1: Type: text/plain, Size: 1797 bytes --]
On 1/7/21 11:57 AM, Richard Purdie wrote:
> On Mon, 2020-12-28 at 21:04 +0100, Alexander Kanavin wrote:
>> Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
>> ---
>> meta/recipes-extended/bash/bash.inc | 1 +
>> .../bash/bash/CVE-2019-18276.patch | 386 ------------------
>> .../bash/bash/build-tests.patch | 16 +-
>> meta/recipes-extended/bash/bash_5.0.bb | 80 ----
>> meta/recipes-extended/bash/bash_5.1.bb | 30 ++
>> 5 files changed, 40 insertions(+), 473 deletions(-)
>> delete mode 100644 meta/recipes-extended/bash/bash/CVE-2019-18276.patch
>> delete mode 100644 meta/recipes-extended/bash/bash_5.0.bb
>> create mode 100644 meta/recipes-extended/bash/bash_5.1.bb
> There is a reproducibility issue in bash 5.1:
>
> https://autobuilder.yocto.io/pub/repro-fail/oe-reproducible-20210107-8jzr3hc5/packages/diff-html/
>
> looks like the issue in in redir.c and I think at a really quick
> glance, the computation of PIPESIZE. Seems to tbe 0x1000 on some
> systems and 0x10000 on others.
>
> bash 5.1 hasn't merged yet and is in master-next.
>
> If nobody else gets to it I will dig further when I have time but
> wanted to mention it.
I looked at this. It appears that bash runs a host program to determine
the pipe size by writing to a pipe until it gets SIGPIPE
(builtin/psize.c). I'm not sure why this would result in a different
size on different hosts... perhaps the pipe size is configurable in the
kernel? Anyway, I suspect that the fix is to add -DHEREDOC_PIPESIZE=4096
to CFLAGS in the recipe.... it's not my favorite fix, but the bash
configure script does the same thing to set the pipe size for FreeBSD.
>
> Cheers,
>
> Richard
>
>
>
>
>
>
[-- Attachment #2: Type: text/html, Size: 2834 bytes --]
next prev parent reply other threads:[~2021-01-07 18:43 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-28 20:04 [PATCH 01/22] devtool: gitsm:// should be handled same as git:// in upgrades Alexander Kanavin
2020-12-28 20:04 ` [PATCH 02/22] ovmf: upgrade 202008 -> 202011 Alexander Kanavin
2020-12-28 20:04 ` [PATCH 03/22] libksba: update 1.4.0 -> 1.5.0 Alexander Kanavin
2020-12-28 20:04 ` [PATCH 04/22] libjitterentropy: update 2.2.0 -> 3.0.0 Alexander Kanavin
2020-12-28 20:04 ` [PATCH 05/22] icu: update 68.1 -> 68.2 Alexander Kanavin
2020-12-28 20:04 ` [PATCH 06/22] gnutls: update 3.6.15 -> 3.7.0 Alexander Kanavin
2020-12-28 20:04 ` [PATCH 07/22] gnupg: update 2.2.23 -> 2.2.26 Alexander Kanavin
2020-12-28 20:04 ` [PATCH 08/22] boost: update 1.74.0 -> 1.75.0 Alexander Kanavin
2020-12-28 20:04 ` [PATCH 09/22] kexec-tools: update 2.0.20 -> 2.0.21 Alexander Kanavin
2020-12-28 20:04 ` [PATCH 10/22] vulkan-samples: update to latest revision Alexander Kanavin
2020-12-28 20:04 ` [PATCH 11/22] libpam: update 1.3.1 -> 1.5.1 Alexander Kanavin
2020-12-28 20:04 ` [PATCH 12/22] autotools.bbclass: make it possible to inhibit m4 deletion Alexander Kanavin
2020-12-28 20:04 ` [PATCH 13/22] bash: update 5.0 -> 5.1 Alexander Kanavin
2021-01-07 17:57 ` [OE-core] " Richard Purdie
2021-01-07 18:43 ` Joshua Watt [this message]
2021-01-07 19:07 ` Otavio Salvador
2021-01-07 19:10 ` Alexander Kanavin
2021-01-07 21:55 ` Richard Purdie
2020-12-28 20:04 ` [PATCH 14/22] strace: update 5.9 -> 5.10 Alexander Kanavin
2020-12-28 20:04 ` [PATCH 15/22] python3-pytest: update 6.1.2 -> 6.2.1 Alexander Kanavin
2020-12-28 20:04 ` [PATCH 16/22] mtools: update 4.0.25 -> 4.0.26 Alexander Kanavin
2020-12-28 20:04 ` [PATCH 17/22] gnu-config: update to latest revision Alexander Kanavin
2020-12-28 20:04 ` [PATCH 18/22] cmake: update 3.18.4 -> 3.19.2 Alexander Kanavin
2020-12-28 20:04 ` [PATCH 19/22] ccache: upgrade 3.7.11 -> 4.1 Alexander Kanavin
2020-12-28 20:04 ` [PATCH 20/22] ccache.bbclass: use ccache from host distribution Alexander Kanavin
2020-12-28 20:04 ` [PATCH 21/22] runtime_test.py: correct output check for bash 5.1 Alexander Kanavin
2020-12-28 20:04 ` [PATCH 22/22] gawk: add missing ptest dependency Alexander Kanavin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a75c31fd-9617-1bc0-e895-ac40802245ce@gmail.com \
--to=jpewhacker@gmail.com \
--cc=alex.kanavin@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox