Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Bruce Ashfield <bruce.ashfield@gmail.com>
To: adrian.freihofer@siemens.com
Cc: openembedded-core@lists.openembedded.org, marex@denx.de,
	a.fatoum@pengutronix.de
Subject: Re: [OE-core] [PATCH v6 10/21] kernel-uboot.bbclass: deploy the vmlinux kernel binary
Date: Mon, 2 Jun 2025 14:51:36 -0400	[thread overview]
Message-ID: <aD3yuMnWwfPcUs3p@gmail.com> (raw)
In-Reply-To: <20250602075714.32122-11-adrian.freihofer@siemens.com>



In message: [OE-core] [PATCH v6 10/21] kernel-uboot.bbclass: deploy the vmlinux kernel binary
on 02/06/2025 Adrian Freihofer via lists.openembedded.org wrote:

> From: Adrian Freihofer <adrian.freihofer@siemens.com>
> 
> Extend the kernel-uboot.bbclass to build and deploy the kernel binary
> intended for inclusion in a FIT image.
> Note that the kernel used in a FIT image is a stripped (and optionally
> compressed) vmlinux ELF binary - not a self-extracting format like
> zImage, which is already available in the deploy directory if needed
> separately.
> 
> The kernel.bbclass inherits all classes listed in the KERNEL_CLASSES
> variable. By default, KERNEL_CLASSES is defined as:
>   KERNEL_CLASSES ?= " kernel-uimage "
> Since kernel-uimage.bbclass inherits from kernel-uboot.bbclass, the
> creation and deployment of the kernel binary for inclusion in a FIT
> image happens automatically by default.
> 
> Signed-off-by: Adrian Freihofer <adrian.freihofer@siemens.com>
> ---
>  meta/classes-recipe/kernel-uboot.bbclass | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/classes-recipe/kernel-uboot.bbclass b/meta/classes-recipe/kernel-uboot.bbclass
> index d2a63524ece..e26ba6f0aa9 100644
> --- a/meta/classes-recipe/kernel-uboot.bbclass
> +++ b/meta/classes-recipe/kernel-uboot.bbclass
> @@ -56,4 +56,13 @@ uboot_prep_kimage() {
>  	fi
>  
>  	printf "$linux_comp" > "$output_dir/linux_comp"
> -}
> \ No newline at end of file
> +}
> +
> +kernel_do_deploy:append() {
> +	# Provide the kernel artifacts to post processing recipes e.g. for creating a FIT image
> +	uboot_prep_kimage "$deployDir"
> +	# For x86 a setup.bin needs to be include"d in a fitImage as well
> +	if [ -e ${KERNEL_OUTPUT_DIR}/setup.bin ]; then
> +		install -D "${B}/${KERNEL_OUTPUT_DIR}/setup.bin" "$deployDir/"
> +	fi

Isn't this adding extra steps / overhead to a user of kernel-uboot
bbclass that isn't building or using a fitimage ?

Bruce

> +}
> -- 
> 2.49.0
> 

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#217701): https://lists.openembedded.org/g/openembedded-core/message/217701
> Mute This Topic: https://lists.openembedded.org/mt/113424435/1050810
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 



  reply	other threads:[~2025-06-02 18:51 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-02  7:56 [PATCH v6 00/21] FIT image improvements AdrianF
2025-06-02  7:56 ` [PATCH v6 01/21] devicetree: minor improvements AdrianF
2025-06-02 18:31   ` [OE-core] " Bruce Ashfield
2025-06-02  7:56 ` [PATCH v6 02/21] oe-selftest: add new ext dtb recipe AdrianF
2025-06-02  7:56 ` [PATCH v6 03/21] oe-selftest: fitimage: test external dtb AdrianF
2025-06-02  7:56 ` [PATCH v6 04/21] oe-selftest: fitimage: test FIT_CONF_PREFIX AdrianF
2025-06-02  7:56 ` [PATCH v6 05/21] oe-selftest: fitimage: test FIT_CONF_DEFAULT_DTB AdrianF
2025-06-02  7:56 ` [PATCH v6 06/21] kernel-signing-keys-native: refactor key generation into a new recipe AdrianF
2025-06-02  7:56 ` [PATCH v6 07/21] maintainers: add myself for kernel-signing-keys-native AdrianF
2025-06-02  7:56 ` [PATCH v6 08/21] oe-selftest: fitimage: cleanup FIT_GENERATE_KEYS AdrianF
2025-06-02  7:56 ` [PATCH v6 09/21] kernel-uboot.bbclass: do not require the kernel build folder AdrianF
2025-06-02  7:56 ` [PATCH v6 10/21] kernel-uboot.bbclass: deploy the vmlinux kernel binary AdrianF
2025-06-02 18:51   ` Bruce Ashfield [this message]
2025-06-02 19:44     ` [OE-core] " Freihofer, Adrian
2025-06-02 19:53       ` Bruce Ashfield
2025-06-02  7:56 ` [PATCH v6 11/21] kernel-fitimage: refactor order in its AdrianF
2025-06-02  7:56 ` [PATCH v6 12/21] kernel-fit-image.bbclass: add a new FIT image implementation AdrianF
2025-06-02 18:12   ` [OE-core] " Bruce Ashfield
2025-06-02  7:56 ` [PATCH v6 13/21] maintainers: add myself for linux-yocto-fitimage AdrianF
2025-06-02  7:56 ` [PATCH v6 14/21] oe-selftest: fitimage: add tests for fitimage.py AdrianF
2025-06-02  7:56 ` [PATCH v6 15/21] oe-selftest: fitimage: support new FIT recipe as well AdrianF
2025-06-02  7:56 ` [PATCH v6 16/21] oe-selftest: fitimage: run all tests for both FIT implementations AdrianF
2025-06-02  7:56 ` [PATCH v6 17/21] oe-selftest: fitimage refactor classes AdrianF
2025-06-02  7:56 ` [PATCH v6 18/21] kernel-fitimage: re-write its code in Python AdrianF
2025-06-02  7:56 ` [PATCH v6 19/21] oe-selftest: fitimage: remove kernel-fitimage tests AdrianF
2025-06-02  7:56 ` [PATCH v6 20/21] kernel.bbclass: remove support for type fitImage AdrianF
2025-06-02 18:59   ` [OE-core] " Bruce Ashfield
2025-06-02  7:56 ` [PATCH v6 21/21] kernel-fitimage.bbclass: remove it AdrianF

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aD3yuMnWwfPcUs3p@gmail.com \
    --to=bruce.ashfield@gmail.com \
    --cc=a.fatoum@pengutronix.de \
    --cc=adrian.freihofer@siemens.com \
    --cc=marex@denx.de \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox