Re: [OE-core] [PATCH] Fixes [YOCTO #15965]

[Mikko Rapeli <mikko.rapeli@linaro.org>]

Hi,

On Wed, Sep 17, 2025 at 07:26:49AM +0000, Barne Carstensen wrote:
> Hello,
> 
> Okay sorry, was my first time sending a patch and in the manual (https://docs.yoctoproject.org/contributor-guide/submit-changes.html#implement-and-commit-changes) was written to use that form. I am a bit in doubt, which branch should I use as reference? The target milestone of the bug is set to 5.3

Is this for master branch or some other? The bug references 5.0 which is scarthgap but
5.3 is for master branch. In master branch this bug should not exist anymore since
e5e8f2aa0a63d fixes this, and 05e97d5e6e24b and 2d900c3061e12 improve
testexport.bbclass usage even more, on par with testimage.bbclass used in
Auto Builder (AB) testing in oe-core/yocto upstream.

> >Since the commits are bit scattered, these from master branch would be needed if not already in the relevant branch:
> 
> >e5e8f2aa0a63d testexport.bbclass oe-test: capture all tests and data from all layers 05e97d5e6e24b oeqa context.py: use TEST_SUITES if set
> >2d900c3061e12 oeqa/runtime: set self.runner and handle None
> 
> I cannot find these commits, but do you ask me to cherry pick these as well?

Yes, the commits are in master branch. They can be cherry-picked to other
branches and hopefully there are not many other changes or adaptations
needed. Then these need to be proposed for that branch on mailing list.

Cheers,

-Mikko

> Thanks for the help and sorry again for the inconvenience. I will try to send the patch again with the right subject and reference branch 😊
>
> Barne
> 
> 
> Classified as Business
> -----Original Message-----
> From: Mikko Rapeli <mikko.rapeli@linaro.org>
> Sent: Dienstag, 16. September 2025 15:41
> To: Barne Carstensen <barne.carstensen@danfoss.com>; openembedded-core@lists.openembedded.org; randy.macleod@windriver.com
> Subject: Re: [OE-core] [PATCH] Fixes [YOCTO #15965]
> 
> [You don't often get email from mikko.rapeli@linaro.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> Hi,
> 
> On Tue, Sep 16, 2025 at 04:09:58PM +0300, Mikko Rapeli via lists.openembedded.org wrote:
> > This is not for master branch and subject line should be something
> > like "[branch name][PATCH] testexport.bbclass: always capture ignore files"
> >
> > On Tue, Sep 16, 2025 at 12:25:22PM +0000, Barne Carstensen via lists.openembedded.org wrote:
> > > Copy all the parselogs-ignores file so that they are always packed
> > > into the testexport.tar.gz (even when testsuite parselog is not
> > > selected)
> > >
> > > Signed-off-by: Barne Carstensen <barne.carstensen@danfoss.com>
> > > CC: randy.macleod@windriver.com
> > > ---
> > >  meta/classes-recipe/testexport.bbclass | 6 ++++++
> > >  1 file changed, 6 insertions(+)
> > >
> > > diff --git a/meta/classes-recipe/testexport.bbclass
> > > b/meta/classes-recipe/testexport.bbclass
> > > index 843d777e3b..2f473a8811 100644
> > > --- a/meta/classes-recipe/testexport.bbclass
> > > +++ b/meta/classes-recipe/testexport.bbclass
> > > @@ -79,6 +79,7 @@ def testexport_main(d):
> > >  def copy_needed_files(d, tc):
> > >      import shutil
> > >      import oe.path
> > > +    import glob
> > >
> > >      from oeqa.utils.package_manager import _get_json_file
> > >      from oeqa.core.utils.test import getSuiteCasesFiles @@ -120,6
> > > +121,11 @@ def copy_needed_files(d, tc):
> > >                      oe.path.copytree(src, dst)
> > >                  else:
> > >                      shutil.copy2(src, dst)
> > > +
> > > +    # Copy all parselogs-ignores files
> > > +    parselogs_ignores = glob.glob(os.path.join(corebase_path, 'meta', 'lib', 'oeqa', 'runtime', 'cases', 'parselogs-ignores-*.txt'))
> > > +    for f in parselogs_ignores:
> > > +         shutil.copy2(f, cases_path)
> >
> > Master branch is quite different. There the tests and their data files
> > are now copied from all enabled layers, not just core.
> > So I would rather port those fixes to relevant branches to avoid
> > duplicating maitenance.
> 
> Since the commits are bit scattered, these from master branch would be needed if not already in the relevant branch:
> 
> e5e8f2aa0a63d testexport.bbclass oe-test: capture all tests and data from all layers 05e97d5e6e24b oeqa context.py: use TEST_SUITES if set
> 2d900c3061e12 oeqa/runtime: set self.runner and handle None
> 
> Cheers,
> 
> -Mikko