diff for duplicates of <aQyg.1702589530747273993.VOVe@lists.openembedded.org> diff --git a/a/1.txt b/N1/1.txt index 70b84fa..ee5f63c 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,6 +1,6 @@ Hi, -I was trying to install the buildtools by using the scripts/install-buildtools script, however the call fails. The issue I found seems a bit weird, as IMHO the script would always fail, hence I am not sure whether it's really an issue or I am misusing the script. Anyway, I am using the script from the openembedded-core - OpenEmbedded Core layer ( https://git.openembedded.org/openembedded-core ) repository, commit 41390f52. +I was trying to install the buildtools by using the scripts/install-buildtools script, however the call fails. The issue I found seems a bit weird, as IMHO the script would always fail, hence I am not sure whether it's really an issue or I am misusing the script. Anyway, I am using the script from the openembedded-core - OpenEmbedded Core layer ( https://git.openembedded.org/openembedded-core ) repository, commit 41390f52 (latest at the time of writing). The command executed: @@ -14,11 +14,11 @@ The command fails and its output is given in [1]. Now, I dug a bit deeper and found two potential issues (if they are even issues, I am not sure anymore). -1. First one is in here ( https://git.openembedded.org/openembedded-core/tree/scripts/install-buildtools#n304 ). Basically, while environment variables are read from build-tools/environment-setup-x86_64-pokysdk-linux (see [2] for its content), some of them are read with double quotes (e.g. PATH ) and as such written in os.environ ( here ( https://git.openembedded.org/openembedded-core/tree/scripts/install-buildtools#n306 ) ), which makes them not correctly used later on. Some come without quotes and are fine to be used (e.g., PKG_CONFIG_LIBDIR ). A solution to this problem is removing the double quotes from envvar if present in the envvar, e.g., ENVVAR="foo" becomes ENVVAR=foo and as such is written in os.environ. +1. First one is in here ( https://git.openembedded.org/openembedded-core/tree/scripts/install-buildtools#n304 ). Basically, while environment variables are read from build-tools/environment-setup-x86_64-pokysdk-linux (see [2] for its content), some of them are read with double quotes (e.g. PATH ) and as such written in os.environ ( here ( https://git.openembedded.org/openembedded-core/tree/scripts/install-buildtools#n306 ) ), which makes them not correctly used later on. Some come without the double quotes and are fine to be used (e.g., PKG_CONFIG_LIBDIR ). A solution to this problem is removing the double quotes from envvar if present in the envvar, e.g., ENVVAR="foo" becomes ENVVAR=foo and as such is written in os.environ. 2. Another issue I found is related to this line ( https://git.openembedded.org/openembedded-core/tree/scripts/install-buildtools#n334 ). If the command is called with --directory , as in my case, the function starts_with will always fail because which_tool will never start with install_dir. The only case where this is not an issue is in when --directory is omitted, since INSTALL_DIR is used in that case and its a full path already. A solution is also simple, we can just check if install_dir is in which_tool , instead of whether which_tool starts with install_dir. -Now my question is am I misunderstanding something or am I misusing the install-buildtools script somehow? If this is really an issue I'd be more than glad to provide a patch. +Now my question is am I misunderstanding something or am I misusing the install-buildtools script somehow? If this is really an issue I'd be more than happy to provide a patch. Cheers Aleksandar diff --git a/a/2.bin b/N1/2.bin index c73d0f7..b97f235 100644 --- a/a/2.bin +++ b/N1/2.bin @@ -1,6 +1,6 @@ -Hi,<br /><br />I was trying to install the <span style="font-family: courier_newregular, courier;">buildtools</span> by using the <span style="font-family: courier_newregular, courier;">scripts/install-buildtools</span> script, however the call fails. The issue I found seems a bit weird, as IMHO the script would always fail, hence I am not sure whether it's really an issue or I am misusing the script. Anyway, I am using the script from the <a href="https://git.openembedded.org/openembedded-core">openembedded-core - OpenEmbedded Core layer</a> repository, commit 41390f52.<br /><br />The command executed:<br /> +Hi,<br /><br />I was trying to install the <span style="font-family: courier_newregular, courier;">buildtools</span> by using the <span style="font-family: courier_newregular, courier;">scripts/install-buildtools</span> script, however the call fails. The issue I found seems a bit weird, as IMHO the script would always fail, hence I am not sure whether it's really an issue or I am misusing the script. Anyway, I am using the script from the <a href="https://git.openembedded.org/openembedded-core" target="_blank" rel="nofollow noopener">openembedded-core - OpenEmbedded Core layer</a> repository, commit 41390f52 (latest at the time of writing).<br /><br />The command executed:<br /> <blockquote>./scripts/install-buildtools --debug --without-extended-buildtools --directory ./build-tools --base-url https://downloads.yoctoproject.org/releases/yocto --release yocto-4.0.14 --installer-version 4.0.14</blockquote> -The command fails and its output is given in [1].<br /><br />Now, I dug a bit deeper and found two potential issues (if they are even issues, I am not sure anymore).<br /><br />1. First one is in <a href="https://git.openembedded.org/openembedded-core/tree/scripts/install-buildtools#n304" target="_blank" rel="noopener">here</a>. Basically, while environment variables are read from <span style="font-family: courier_newregular, courier;">build-tools/environment-setup-x86_64-pokysdk-linux</span> (see [2] for its content), some of them are read with double quotes (e.g. <span style="font-family: courier_newregular, courier;">PATH</span>) and as such written in <span style="font-family: courier_newregular, courier;">os.environ</span> (<a href="https://git.openembedded.org/openembedded-core/tree/scripts/install-buildtools#n306" target="_blank" rel="noopener">here</a>), which makes them not correctly used later on. Some come without quotes and are fine to be used (e.g., <span style="font-family: courier_newregular, courier;">PKG_CONFIG_LIBDIR</span>). A solution to this problem is removing the double quotes from envvar if present in the envvar, e.g., <span style="font-family: courier_newregular, courier;">ENVVAR="foo"</span> becomes <span style="font-family: courier_newregular, courier;">ENVVAR=foo</span> and as such is written in <span style="font-family: courier_newregular, courier;">os.environ</span>.<br /><br />2. Another issue I found is related to <a href="https://git.openembedded.org/openembedded-core/tree/scripts/install-buildtools#n334" target="_blank" rel="noopener">this line</a>. If the command is called with <span style="font-family: courier_newregular, courier;">--directory</span>, as in my case, the function <span style="font-family: courier_newregular, courier;">starts_with</span> will always fail because <span style="font-family: courier_newregular, courier;">which_tool</span> will never start with <span style="color: #000000; font-family: Menlo, Monaco, Consolas, 'Courier New', monospace; font-size: 13.3333px;"><span style="font-family: courier_newregular, courier;">install_dir</span>.</span> The only case where this is not an issue is in when <span style="font-family: courier_newregular, courier;">--directory</span> is omitted, since <span style="font-family: courier_newregular, courier;">INSTALL_DIR</span> is used in that case and its a full path already. A solution is also simple, we can just check if <span style="color: #000000; font-family: courier_newregular, courier; font-size: 13.3333px;">install_dir </span>is in <span style="font-family: courier_newregular, courier;">which_tool<span style="font-family: helvetica;">, instead of whether <span style="font-family: courier_newregular, courier;">which_tool</span> starts with <span style="font-family: courier_newregular, courier;">install_dir</span>.</span></span><br /><br />Now my question is am I misunderstanding something or am I misusing the <span style="font-family: courier_newregular, courier;">install-buildtools</span> script somehow? If this is really an issue I'd be more than glad to provide a patch.<br /><br />Cheers<br />Aleksandar<br /><br />[1]<br /> +The command fails and its output is given in [1].<br /><br />Now, I dug a bit deeper and found two potential issues (if they are even issues, I am not sure anymore).<br /><br />1. First one is in <a href="https://git.openembedded.org/openembedded-core/tree/scripts/install-buildtools#n304" target="_blank" rel="nofollow noopener">here</a>. Basically, while environment variables are read from <span style="font-family: courier_newregular, courier;">build-tools/environment-setup-x86_64-pokysdk-linux</span> (see [2] for its content), some of them are read with double quotes (e.g. <span style="font-family: courier_newregular, courier;">PATH</span>) and as such written in <span style="font-family: courier_newregular, courier;">os.environ</span> (<a href="https://git.openembedded.org/openembedded-core/tree/scripts/install-buildtools#n306" target="_blank" rel="nofollow noopener">here</a>), which makes them not correctly used later on. Some come without the double quotes and are fine to be used (e.g., <span style="font-family: courier_newregular, courier;">PKG_CONFIG_LIBDIR</span>). A solution to this problem is removing the double quotes from envvar if present in the envvar, e.g., <span style="font-family: courier_newregular, courier;">ENVVAR="foo"</span> becomes <span style="font-family: courier_newregular, courier;">ENVVAR=foo</span> and as such is written in <span style="font-family: courier_newregular, courier;">os.environ</span>.<br /><br />2. Another issue I found is related to <a href="https://git.openembedded.org/openembedded-core/tree/scripts/install-buildtools#n334" target="_blank" rel="nofollow noopener">this line</a>. If the command is called with <span style="font-family: courier_newregular, courier;">--directory</span>, as in my case, the function <span style="font-family: courier_newregular, courier;">starts_with</span> will always fail because <span style="font-family: courier_newregular, courier;">which_tool</span> will never start with <span style="color: #000000; font-family: Menlo, Monaco, Consolas, 'Courier New', monospace; font-size: 13.3333px;"><span style="font-family: courier_newregular, courier;">install_dir</span>.</span> The only case where this is not an issue is in when <span style="font-family: courier_newregular, courier;">--directory</span> is omitted, since <span style="font-family: courier_newregular, courier;">INSTALL_DIR</span> is used in that case and its a full path already. A solution is also simple, we can just check if <span style="color: #000000; font-family: courier_newregular, courier; font-size: 13.3333px;">install_dir </span>is in <span style="font-family: courier_newregular, courier;">which_tool<span style="font-family: helvetica;">, instead of whether <span style="font-family: courier_newregular, courier;">which_tool</span> starts with <span style="font-family: courier_newregular, courier;">install_dir</span>.</span></span><br /><br />Now my question is am I misunderstanding something or am I misusing the <span style="font-family: courier_newregular, courier;">install-buildtools</span> script somehow? If this is really an issue I'd be more than happy to provide a patch.<br /><br />Cheers<br />Aleksandar<br /><br />[1]<br /> <blockquote> <div>DEBUG: milestone regex: None</div> <div>INFO: Fetching buildtools installer</div> diff --git a/a/2.hdr b/N1/2.hdr index 24bd2b6..6a9de1e 100644 --- a/a/2.hdr +++ b/N1/2.hdr @@ -1,2 +1,2 @@ -Content-Type: text/html; charset="utf-8" +Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable diff --git a/a/content_digest b/N1/content_digest index 3c5525c..34ec302 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,12 +1,12 @@ "From\0Aleksandar Nikolic <an010@live.com>\0" "Subject\0install-buildtools fails #poky\0" - "Date\0Thu, 14 Dec 2023 13:32:10 -0800\0" + "Date\0Thu, 14 Dec 2023 13:34:37 -0800\0" "To\0openembedded-core@lists.openembedded.org\0" "\01:1\0" "b\0" "Hi,\n" "\n" - "I was trying to install the buildtools by using the scripts/install-buildtools script, however the call fails. The issue I found seems a bit weird, as IMHO the script would always fail, hence I am not sure whether it's really an issue or I am misusing the script. Anyway, I am using the script from the openembedded-core - OpenEmbedded Core layer ( https://git.openembedded.org/openembedded-core ) repository, commit\302\24041390f52.\n" + "I was trying to install the buildtools by using the scripts/install-buildtools script, however the call fails. The issue I found seems a bit weird, as IMHO the script would always fail, hence I am not sure whether it's really an issue or I am misusing the script. Anyway, I am using the script from the openembedded-core - OpenEmbedded Core layer ( https://git.openembedded.org/openembedded-core ) repository, commit\302\24041390f52 (latest at the time of writing).\n" "\n" "The command executed:\n" "\n" @@ -20,11 +20,11 @@ "\n" "Now, I dug a bit deeper and found two potential issues (if they are even issues, I am not sure anymore).\n" "\n" - "1. First one is in here ( https://git.openembedded.org/openembedded-core/tree/scripts/install-buildtools#n304 ). Basically, while environment variables are read from build-tools/environment-setup-x86_64-pokysdk-linux (see [2] for its content), some of them are read with double quotes (e.g. PATH ) and as such written in os.environ ( here ( https://git.openembedded.org/openembedded-core/tree/scripts/install-buildtools#n306 ) ), which makes them not correctly used later on. Some come without quotes and are fine to be used (e.g., PKG_CONFIG_LIBDIR ). A solution to this problem is removing the double quotes from envvar if present in the envvar, e.g., ENVVAR=\"foo\" becomes ENVVAR=foo and as such is written in os.environ.\n" + "1. First one is in here ( https://git.openembedded.org/openembedded-core/tree/scripts/install-buildtools#n304 ). Basically, while environment variables are read from build-tools/environment-setup-x86_64-pokysdk-linux (see [2] for its content), some of them are read with double quotes (e.g. PATH ) and as such written in os.environ ( here ( https://git.openembedded.org/openembedded-core/tree/scripts/install-buildtools#n306 ) ), which makes them not correctly used later on. Some come without the double quotes and are fine to be used (e.g., PKG_CONFIG_LIBDIR ). A solution to this problem is removing the double quotes from envvar if present in the envvar, e.g., ENVVAR=\"foo\" becomes ENVVAR=foo and as such is written in os.environ.\n" "\n" "2. Another issue I found is related to this line ( https://git.openembedded.org/openembedded-core/tree/scripts/install-buildtools#n334 ). If the command is called with --directory , as in my case, the function starts_with will always fail because which_tool will never start with install_dir. The only case where this is not an issue is in when --directory is omitted, since INSTALL_DIR is used in that case and its a full path already. A solution is also simple, we can just check if install_dir is in which_tool , instead of whether which_tool starts with install_dir.\n" "\n" - "Now my question is am I misunderstanding something or am I misusing the install-buildtools script somehow? If this is really an issue I'd be more than glad to provide a patch.\n" + "Now my question is am I misunderstanding something or am I misusing the install-buildtools script somehow? If this is really an issue I'd be more than happy to provide a patch.\n" "\n" "Cheers\n" "Aleksandar\n" @@ -163,9 +163,9 @@ > "\01:2\0" "b\0" - "Hi,<br /><br />I was trying to install the <span style=\"font-family: courier_newregular, courier;\">buildtools</span> by using the <span style=\"font-family: courier_newregular, courier;\">scripts/install-buildtools</span> script, however the call fails. The issue I found seems a bit weird, as IMHO the script would always fail, hence I am not sure whether it's really an issue or I am misusing the script. Anyway, I am using the script from the <a href=\"https://git.openembedded.org/openembedded-core\">openembedded-core - OpenEmbedded Core layer</a> repository, commit 41390f52.<br /><br />The command executed:<br />\r\n" + "Hi,<br /><br />I was trying to install the <span style=\"font-family: courier_newregular, courier;\">buildtools</span> by using the <span style=\"font-family: courier_newregular, courier;\">scripts/install-buildtools</span> script, however the call fails. The issue I found seems a bit weird, as IMHO the script would always fail, hence I am not sure whether it's really an issue or I am misusing the script. Anyway, I am using the script from the <a href=\"https://git.openembedded.org/openembedded-core\" target=\"_blank\" rel=\"nofollow noopener\">openembedded-core - OpenEmbedded Core layer</a> repository, commit 41390f52 (latest at the time of writing).<br /><br />The command executed:<br />\r\n" "<blockquote>./scripts/install-buildtools --debug --without-extended-buildtools --directory ./build-tools --base-url https://downloads.yoctoproject.org/releases/yocto --release yocto-4.0.14 --installer-version 4.0.14</blockquote>\r\n" - "The command fails and its output is given in [1].<br /><br />Now, I dug a bit deeper and found two potential issues (if they are even issues, I am not sure anymore).<br /><br />1. First one is in <a href=\"https://git.openembedded.org/openembedded-core/tree/scripts/install-buildtools#n304\" target=\"_blank\" rel=\"noopener\">here</a>. Basically, while environment variables are read from <span style=\"font-family: courier_newregular, courier;\">build-tools/environment-setup-x86_64-pokysdk-linux</span> (see [2] for its content), some of them are read with double quotes (e.g. <span style=\"font-family: courier_newregular, courier;\">PATH</span>) and as such written in <span style=\"font-family: courier_newregular, courier;\">os.environ</span> (<a href=\"https://git.openembedded.org/openembedded-core/tree/scripts/install-buildtools#n306\" target=\"_blank\" rel=\"noopener\">here</a>), which makes them not correctly used later on. Some come without quotes and are fine to be used (e.g., <span style=\"font-family: courier_newregular, courier;\">PKG_CONFIG_LIBDIR</span>). A solution to this problem is removing the double quotes from envvar if present in the envvar, e.g., <span style=\"font-family: courier_newregular, courier;\">ENVVAR=\"foo\"</span> becomes <span style=\"font-family: courier_newregular, courier;\">ENVVAR=foo</span> and as such is written in <span style=\"font-family: courier_newregular, courier;\">os.environ</span>.<br /><br />2. Another issue I found is related to <a href=\"https://git.openembedded.org/openembedded-core/tree/scripts/install-buildtools#n334\" target=\"_blank\" rel=\"noopener\">this line</a>. If the command is called with <span style=\"font-family: courier_newregular, courier;\">--directory</span>, as in my case, the function <span style=\"font-family: courier_newregular, courier;\">starts_with</span> will always fail because <span style=\"font-family: courier_newregular, courier;\">which_tool</span> will never start with <span style=\"color: #000000; font-family: Menlo, Monaco, Consolas, 'Courier New', monospace; font-size: 13.3333px;\"><span style=\"font-family: courier_newregular, courier;\">install_dir</span>.</span> The only case where this is not an issue is in when <span style=\"font-family: courier_newregular, courier;\">--directory</span> is omitted, since <span style=\"font-family: courier_newregular, courier;\">INSTALL_DIR</span> is used in that case and its a full path already. A solution is also simple, we can just check if <span style=\"color: #000000; font-family: courier_newregular, courier; font-size: 13.3333px;\">install_dir </span>is in <span style=\"font-family: courier_newregular, courier;\">which_tool<span style=\"font-family: helvetica;\">, instead of whether <span style=\"font-family: courier_newregular, courier;\">which_tool</span> starts with <span style=\"font-family: courier_newregular, courier;\">install_dir</span>.</span></span><br /><br />Now my question is am I misunderstanding something or am I misusing the <span style=\"font-family: courier_newregular, courier;\">install-buildtools</span> script somehow? If this is really an issue I'd be more than glad to provide a patch.<br /><br />Cheers<br />Aleksandar<br /><br />[1]<br />\r\n" + "The command fails and its output is given in [1].<br /><br />Now, I dug a bit deeper and found two potential issues (if they are even issues, I am not sure anymore).<br /><br />1. First one is in <a href=\"https://git.openembedded.org/openembedded-core/tree/scripts/install-buildtools#n304\" target=\"_blank\" rel=\"nofollow noopener\">here</a>. Basically, while environment variables are read from <span style=\"font-family: courier_newregular, courier;\">build-tools/environment-setup-x86_64-pokysdk-linux</span> (see [2] for its content), some of them are read with double quotes (e.g. <span style=\"font-family: courier_newregular, courier;\">PATH</span>) and as such written in <span style=\"font-family: courier_newregular, courier;\">os.environ</span> (<a href=\"https://git.openembedded.org/openembedded-core/tree/scripts/install-buildtools#n306\" target=\"_blank\" rel=\"nofollow noopener\">here</a>), which makes them not correctly used later on. Some come without the double quotes and are fine to be used (e.g., <span style=\"font-family: courier_newregular, courier;\">PKG_CONFIG_LIBDIR</span>). A solution to this problem is removing the double quotes from envvar if present in the envvar, e.g., <span style=\"font-family: courier_newregular, courier;\">ENVVAR=\"foo\"</span> becomes <span style=\"font-family: courier_newregular, courier;\">ENVVAR=foo</span> and as such is written in <span style=\"font-family: courier_newregular, courier;\">os.environ</span>.<br /><br />2. Another issue I found is related to <a href=\"https://git.openembedded.org/openembedded-core/tree/scripts/install-buildtools#n334\" target=\"_blank\" rel=\"nofollow noopener\">this line</a>. If the command is called with <span style=\"font-family: courier_newregular, courier;\">--directory</span>, as in my case, the function <span style=\"font-family: courier_newregular, courier;\">starts_with</span> will always fail because <span style=\"font-family: courier_newregular, courier;\">which_tool</span> will never start with <span style=\"color: #000000; font-family: Menlo, Monaco, Consolas, 'Courier New', monospace; font-size: 13.3333px;\"><span style=\"font-family: courier_newregular, courier;\">install_dir</span>.</span> The only case where this is not an issue is in when <span style=\"font-family: courier_newregular, courier;\">--directory</span> is omitted, since <span style=\"font-family: courier_newregular, courier;\">INSTALL_DIR</span> is used in that case and its a full path already. A solution is also simple, we can just check if <span style=\"color: #000000; font-family: courier_newregular, courier; font-size: 13.3333px;\">install_dir </span>is in <span style=\"font-family: courier_newregular, courier;\">which_tool<span style=\"font-family: helvetica;\">, instead of whether <span style=\"font-family: courier_newregular, courier;\">which_tool</span> starts with <span style=\"font-family: courier_newregular, courier;\">install_dir</span>.</span></span><br /><br />Now my question is am I misunderstanding something or am I misusing the <span style=\"font-family: courier_newregular, courier;\">install-buildtools</span> script somehow? If this is really an issue I'd be more than happy to provide a patch.<br /><br />Cheers<br />Aleksandar<br /><br />[1]<br />\r\n" "<blockquote>\r\n" "<div>DEBUG: milestone regex: None</div>\r\n" "<div>INFO: Fetching buildtools installer</div>\r\n" @@ -251,4 +251,4 @@ "</div>\r\n" "</blockquote>\r\n" -8dddf973aa6a301868fc7798733458f792950bc38d16d6ece5227aafbeb3cece +89fa1a537e6f1cc7f174b2144295357aa6def12723ae79502c32dbe2df3844ae
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox