From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Ross Burton <ross.burton@intel.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] package_manager: don't search for binaries in $PATH explicitly
Date: Sat, 15 Dec 2018 11:57:26 +0000 [thread overview]
Message-ID: <aaeddd16974eda95393a5a528ee3b864c12353af.camel@linuxfoundation.org> (raw)
In-Reply-To: <20181214171051.2030-1-ross.burton@intel.com>
On Fri, 2018-12-14 at 17:10 +0000, Ross Burton wrote:
> There's no point in looking for a command on $PATH using
> bb.utils.which() but
> then passing it to subprocess.check*() which will search $PATH.
>
> By just using the command directly, the code is visibly neater.
>
> Signed-off-by: Ross Burton <ross.burton@intel.com>
> ---
> meta/lib/oe/package_manager.py | 43 +++++++++++++++++++++-----------
> ----------
> 1 file changed, 21 insertions(+), 22 deletions(-)
This needs refreshing once the confusion with it and the runqemu path
is sorted!
Cheers,
Richard
prev parent reply other threads:[~2018-12-15 11:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-14 17:10 [PATCH] package_manager: don't search for binaries in $PATH explicitly Ross Burton
2018-12-14 17:52 ` ✗ patchtest: failure for " Patchwork
2018-12-15 11:57 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaeddd16974eda95393a5a528ee3b864c12353af.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox