Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Michael Halstead <mhalstead@linuxfoundation.org>,
	openembedded-core@lists.openembedded.org
Subject: Re: [OE-core][PATCH] scripts/autobuilder-worker-prereq-tests: jinja2 check
Date: Thu, 14 Oct 2021 22:40:25 +0100	[thread overview]
Message-ID: <abb979abb8b4397550022bd5194e500ec58f9fa7.camel@linuxfoundation.org> (raw)
In-Reply-To: <20211014175543.85257-1-mhalstead@linuxfoundation.org>

On Thu, 2021-10-14 at 10:55 -0700, Michael Halstead wrote:
> Ensure the jinja2 module is available during bringup.
> 
> Signed-off-by: Michael Halstead <mhalstead@linuxfoundation.org>
> ---
>  scripts/autobuilder-worker-prereq-tests | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/scripts/autobuilder-worker-prereq-tests b/scripts/autobuilder-worker-prereq-tests
> index 5d7e6e2601..82e9a77bd5 100755
> --- a/scripts/autobuilder-worker-prereq-tests
> +++ b/scripts/autobuilder-worker-prereq-tests
> @@ -35,6 +35,11 @@ if [ "$?" != "0" ]; then
>      echo "Please set git config --global user.email"
>      exit 1
>  fi
> +python3 -c "import jinja2"
> +if [ "$?" != "0" ]; then
> +    echo "Please ensure jinja2 is available"
> +    exit 1
> +fi
>  bitbake -p
>  if [ "$?" != "0" ]; then
>      echo "Bitbake parsing failed"

Looks good, thanks, I merged it. Should we cover rsync with a test too?

Cheers,

Richard



      reply	other threads:[~2021-10-14 21:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-14 17:55 [OE-core][PATCH] scripts/autobuilder-worker-prereq-tests: jinja2 check Michael Halstead
2021-10-14 21:40 ` Richard Purdie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=abb979abb8b4397550022bd5194e500ec58f9fa7.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=mhalstead@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox