Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: twoerner@gmail.com, openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] harfbuzz: remove meson flag work-around
Date: Sat, 26 Apr 2025 09:44:35 +0100	[thread overview]
Message-ID: <ac75dceaa2685abbd18fe4005f35d561e4ee75a1.camel@linuxfoundation.org> (raw)
In-Reply-To: <20250425174215.19853-1-twoerner@gmail.com>

On Fri, 2025-04-25 at 13:42 -0400, Trevor Woerner via lists.openembedded.org wrote:
> The issue is committed and resolved upstream, therefore remove the
> work-around of explicitly having to set the meson flag 'cpp_std=c++17' when
> using icu >= 75.
> 
> https://github.com/harfbuzz/harfbuzz/issues/4671
> https://github.com/harfbuzz/harfbuzz/pull/4734
> 
> Signed-off-by: Trevor Woerner <twoerner@gmail.com>
> ---
>  meta/recipes-graphics/harfbuzz/harfbuzz_11.0.1.bb | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/meta/recipes-graphics/harfbuzz/harfbuzz_11.0.1.bb b/meta/recipes-graphics/harfbuzz/harfbuzz_11.0.1.bb
> index 8945467a001d..2febcbecda31 100644
> --- a/meta/recipes-graphics/harfbuzz/harfbuzz_11.0.1.bb
> +++ b/meta/recipes-graphics/harfbuzz/harfbuzz_11.0.1.bb
> @@ -32,9 +32,6 @@ PACKAGES =+ "${PN}-icu ${PN}-icu-dev ${PN}-subset"
>  
>  LEAD_SONAME = "libharfbuzz.so"
>  
> -# Remove when https://github.com/harfbuzz/harfbuzz/issues/4671 is resolved
> -EXTRA_OEMESON += "-Dcpp_std=c++17"
> -
>  do_install:append() {
>      # If no tools are installed due to PACKAGECONFIG then this directory might
>      # still be installed, so remove it to stop packaging warnings.
> 

Removing this caused failures on the autobuilder with gcc 15 e.g.:

https://autobuilder.yoctoproject.org/valkyrie/#/builders/2/builds/1474

but there were more in that build.

Cheers,

Richard


  reply	other threads:[~2025-04-26  8:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-25 17:42 [PATCH] harfbuzz: remove meson flag work-around Trevor Woerner
2025-04-26  8:44 ` Richard Purdie [this message]
     [not found] ` <1839D1DE491F347B.938@lists.openembedded.org>
2025-04-26  9:45   ` [OE-core] " Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ac75dceaa2685abbd18fe4005f35d561e4ee75a1.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=twoerner@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox