From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mail.openembedded.org (Postfix) with ESMTP id 810E771B42 for ; Mon, 17 Oct 2016 15:15:05 +0000 (UTC) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP; 17 Oct 2016 08:15:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,357,1473145200"; d="scan'208,217";a="773614091" Received: from lsandov1-mobl2.zpn.intel.com (HELO [10.219.5.38]) ([10.219.5.38]) by FMSMGA003.fm.intel.com with ESMTP; 17 Oct 2016 08:15:05 -0700 To: "Burton, Ross" References: <5458be631bd0e452a6b05b09e9b86d6fbf567eeb.1476462963.git.leonardo.sandoval.gonzalez@linux.intel.com> From: Leonardo Sandoval Message-ID: Date: Mon, 17 Oct 2016 10:19:17 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Cc: OE-core Subject: Re: [PATCH 4/9] selftest: skip some devtool tests when distro is poky-tiny due to missing libx11 X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2016 15:15:08 -0000 Content-Type: multipart/alternative; boundary="------------E3C0B590BDF457010EE58970" --------------E3C0B590BDF457010EE58970 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 10/17/2016 06:42 AM, Burton, Ross wrote: > > On 14 October 2016 at 17:40, > > wrote: > > def test_devtool_add_fetch_git(self): > - # Fetch source > + if self.distro == 'poky-tiny': > + self.skipTest('libmatchbox2 is not buildable with > poky-tiny because it requires a libx11 provider') > tempdir = tempfile.mkdtemp(prefix='devtoolqa') > self.track_for_cleanup(tempdir) > url = 'git://git.yoctoproject.org/libmatchbox > ' > > > Changing the test to use a recipe that doesn't require a distro > feature that many distros disable seems like a more sustainable fix. > Which recipe do you think would be more generic? > Ross --------------E3C0B590BDF457010EE58970 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 8bit



On 10/17/2016 06:42 AM, Burton, Ross wrote:

On 14 October 2016 at 17:40, <leonardo.sandoval.gonzalez@linux.intel.com> wrote:
     def test_devtool_add_fetch_git(self):
-        # Fetch source
+        if self.distro == 'poky-tiny':
+            self.skipTest('libmatchbox2 is not buildable with poky-tiny because it requires a libx11 provider')
         tempdir = tempfile.mkdtemp(prefix='devtoolqa')
         self.track_for_cleanup(tempdir)
         url = 'git://git.yoctoproject.org/libmatchbox'

Changing the test to use a recipe that doesn't require a distro feature that many distros disable seems like a more sustainable fix.

Which recipe do you think would be more generic?
Ross

--------------E3C0B590BDF457010EE58970--