Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Randy MacLeod <randy.macleod@windriver.com>
To: Trevor Gamblin <Trevor.Gamblin@windriver.com>,
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/2] quilt: Export missing QUILT_PC variable in ptest Makefile
Date: Wed, 21 Aug 2019 22:59:37 -0400	[thread overview]
Message-ID: <ad31f9c1-2fcf-bffe-3695-e52d13868434@windriver.com> (raw)
In-Reply-To: <1566417666-22515-1-git-send-email-Trevor.Gamblin@windriver.com>

    quilt: Export missing QUILT_PC variable in ptest Makefile
is over the 50 character suggested short summary limit:
    quilt: Export QUILT_PC variable in ptest Makefile
works. :)

On 8/21/19 4:01 PM, Trevor Gamblin wrote:
> From: Trevor Gamblin <trevor.gamblin@windriver.com>
> 
> The quilt ptest uses a custom Makefile to implement the
> "make check" rule, but the ptest Makefile does not export
> the value QUILT_PC, which is user-settable and normally
s/value/variable/
> defaults to ".pc". This causes failures e.g. import.test
> with "rm -rf patches/ %{QUILT_PC}/", evaluating to
> "rm -rf patches/ /" if the variable is not set by the
> Makefile. 

Add that:

These ptests broke in:
   73d6034f6b quilt: update to 0.66
when the upstream quilt developers enabled users to specify
their own QUILT_PC string.

../Randy


> 
> Signed-off-by: Trevor Gamblin <trevor.gamblin@windriver.com>
> ---
>   meta/recipes-devtools/quilt/quilt/Makefile | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-devtools/quilt/quilt/Makefile b/meta/recipes-devtools/quilt/quilt/Makefile
> index 7b3ac8a..1f6cd24 100644
> --- a/meta/recipes-devtools/quilt/quilt/Makefile
> +++ b/meta/recipes-devtools/quilt/quilt/Makefile
> @@ -2,7 +2,8 @@ PATH :=         $(CURDIR)/bin:$(CURDIR)/compat:$(PATH)
>   QUILT_DIR :=    $(CURDIR)/quilt
>   QUILTRC :=      $(CURDIR)/test/test.quiltrc
>   export QUILT_DIR QUILTRC
> -CHECK_ENV := P=patches/; _P=../patches/; export P _P
> +CHECK_ENV := P=patches/; _P=../patches/; export P _P;
> +CHECK_ENV += QUILT_PC=.pc; export QUILT_PC
>   -include test/.depend
>   
>   check-% : test/%.test
> 


-- 
# Randy MacLeod
# Wind River Linux


      parent reply	other threads:[~2019-08-22  3:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-21 20:01 [PATCH 1/2] quilt: Export missing QUILT_PC variable in ptest Makefile Trevor Gamblin
2019-08-21 20:01 ` [PATCH 2/2] quilt: added less to RDEPENDS list Trevor Gamblin
2019-08-22  2:43   ` Randy MacLeod
2019-08-22  3:35     ` Andre McCurdy
2019-08-22  2:59 ` Randy MacLeod [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ad31f9c1-2fcf-bffe-3695-e52d13868434@windriver.com \
    --to=randy.macleod@windriver.com \
    --cc=Trevor.Gamblin@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox