Re: [OE-core] [PATCH v9 4/5] wic: move canned *wks files

Richard Purdie
2026-04-03T21:13:14Z

On Fri, 2026-04-03 at 14:35 -0400, Trevor Woerner via lists.openembedded.org wrote:
> When "wic create ..." is invoked with a bare *wks name (i.e. without the
> `.wks` extension), wic calls engine.py:find_canned_images() to find the
> fully qualified *wks file. This function searches every directory formed by:
>     - permutating all BBLAYERS with `/wic`
>     - permutating all BBLAYERS with `/scripts/lib/wic/canned-wks`
>     - checking `<scripts_path>/lib/wic/canned-wks`
> Where `<scripts_path>` is the directory containing the wic program.

It doesn't. I just looked at the code and it uses BBPATH. That can be
similar to BBLAYERS but it is different and the commit messages really
should refer to BBPATH.

> When wic is part of oe-core, the last search path succeeds in finding
> the canned *wks files in `<topdir>/scripts/lib/wic/canned-wks` (since
> the wic program is found in oe-core's `<topdir>/scripts` directory, and
> `<topdir>/scripts` is not a BBLAYER).
>
> However, once wic is removed from oe-core, this algorithm will not find
> these bare *wks files in any of the above-mentioned search paths since
> the oe-core layer will no longer be the home of the wic program, and the
> canned *wks files are not located in any directory relative to BBLAYERS.

I'm a bit confused by this reasoning. Are you saying that wic will no
longer search BBPATH (or WKS_SEARCH_PATH)?

> Since these *wks files are specific to oe-core's meta layer, they should
> stay with this layer. Therefore move the *wks files so they exist in one
> of the locations searched relative to oe-core/meta's BBLAYERS.

I don't understand why these need to move given WKS_SEARCH_PATH remains
unchanged, unless wic is going to ignore WKS_SEARCH_PATH going forward?

Cheers,

Richard