Openembedded Core Discussions
 help / color / mirror / Atom feed
From: "Richard Purdie" <richard.purdie@linuxfoundation.org>
To: Andre McCurdy <armccurdy@gmail.com>
Cc: OE Core mailing list <openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH 3/3] meta: Manual override fixes
Date: Wed, 28 Jul 2021 22:28:29 +0100	[thread overview]
Message-ID: <ade5b1fc3b4c5eba393ee15e0db44511c02bbfb5.camel@linuxfoundation.org> (raw)
In-Reply-To: <CAJ86T=WoknfuEhtgS3dOL=Xz1jsjPCViU5jXSTy703vK9cijCg@mail.gmail.com>

On Wed, 2021-07-28 at 14:21 -0700, Andre McCurdy wrote:
> On Wed, Jul 28, 2021 at 1:54 PM Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > 
> > On Wed, 2021-07-28 at 13:43 -0700, Andre McCurdy wrote:
> > 
> > > Since the script will be reused many times for many private layers I'd
> > > say making it as robust as possible is a worthy goal.
> > 
> > Well, sure. I have spent days on it and improved it several times over compared
> > to what it did do. I have it working for 10,000 cases in OE-Core with around 40
> > exceptions which I didn't think was too bad. I felt I'd reached the point of
> > diminishing returns with it. As with most things, we can improve it and patches
> > are welcome.
> 
> Unfortunately those most affected by shortcomings in the script are
> probably also those least likely to submit patches for it. Just as
> those most affected by the new recipe syntax were probably not reading
> oe-arch when you proposed the change and asked for feedback. They will
> instead find out about it months or years from now when they discover
> their meta layers don't work when they try using a new release of OE.
> At that point a lot of them will just shug and keep on using 3.1
> LTS...
> 
> > I'm more worried that the patterns of metadata in the wild may be quite different
> > to what we've trained the script with in OE-Core too, that may be a much more
> > important issue.
> 
> Yes, that's a concern too. Looking at the script now it seems to be
> mostly a long list of exceptions. The chances of it working well on
> layers you haven't considered don't look too good.

I'm not sure that is entirely true/fair. The bulk of the exceptions are for 
python function/variable names and OE-Core and bitbake itself have a much 
higher fraction of code like that than most layers do.

I am interested in real world feedback on layers people can test it against
though to see how much of an issue that really is.

The goal here isn't 100% perfect automated conversion (in which case bitbake 
could just markup things internally) but to help people convert layers with
minimal pain.

Cheers,

Richard



  reply	other threads:[~2021-07-28 21:28 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-28 14:15 [PATCH 1/3] scripts/contrib: Add override conversion script Richard Purdie
2021-07-28 14:15 ` [PATCH 2/3] Convert to new override syntax Richard Purdie
2021-07-28 14:15 ` [PATCH 3/3] meta: Manual override fixes Richard Purdie
2021-07-28 19:32   ` [OE-core] " Andre McCurdy
2021-07-28 20:00     ` Richard Purdie
     [not found]     ` <16960CD0F3F5D3AD.12099@lists.openembedded.org>
2021-07-28 20:24       ` Richard Purdie
2021-07-28 20:43         ` Andre McCurdy
2021-07-28 20:53           ` Richard Purdie
2021-07-28 21:21             ` Andre McCurdy
2021-07-28 21:28               ` Richard Purdie [this message]
     [not found]               ` <169611A4DF65986F.13113@lists.openembedded.org>
2021-07-28 22:42                 ` Richard Purdie
2021-07-28 14:52 ` [OE-core] [PATCH 1/3] scripts/contrib: Add override conversion script Michael Opdenacker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ade5b1fc3b4c5eba393ee15e0db44511c02bbfb5.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=armccurdy@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox